1613117 - Crash in [@ mozilla::webgpu::WebGPUChild::DeviceCreateShaderModule]

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P2)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

This bug is for crash report bp-b23265d2-6d79-41a3-a7fe-2f6bf0200202.

Top 10 frames of crashing thread:

0 xul.dll mozilla::webgpu::WebGPUChild::DeviceCreateShaderModule dom/webgpu/ipc/WebGPUChild.cpp:186
1 xul.dll mozilla::webgpu::Device::CreateShaderModule dom/webgpu/Device.cpp:160
2 xul.dll mozilla::dom::GPUDevice_Binding::createShaderModule dom/bindings/WebGPUBinding.cpp:11088
3 xul.dll mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3151
4 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:561
5 xul.dll Interpret js/src/vm/Interpreter.cpp:3036
6 xul.dll js::RunScript js/src/vm/Interpreter.cpp:441
7 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:596
8 xul.dll js::Call js/src/vm/Interpreter.cpp:641
9 xul.dll js::CallSelfHostedFunction js/src/vm/SelfHosting.cpp:1694

A dozen crashes on nightly over the last week with this new signature.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:kvark, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Dzmitry Malyshau [:kvark]]

I think what's happening is the createShaderModule being called with a DOMString parameter instead of Uint32Array, and we are not properly handling that yet. A trivial fix would be throwing an exception.

Comment 3

[Gary [:streetwolf52]]

How close is WebGPU ready to ride the train?

Comment 4

[Darkspirit]

(In reply to Gary [:streetwolf52] from comment #3)

How close is WebGPU ready to ride the train?

Nightly-only (bug 1616741)

Comment 5

[Gary [:streetwolf52]]

But as this bug report shows it crashes when I try out the demos for it so it is riding under the train. Was wondering when it will work.

Comment 6

[Gary [:streetwolf52]]

Here's the demo site if you don't already know about it:

https://webkit.org/demos/webgpu/

Comment 7

[Dzmitry Malyshau [:kvark]]

You are enabling an experimental feature "dom.webgpu.enabled", which isn't providing any guarantees (yet).
This demo will work once 1) it's ported to WGSL, and 2) our implementation supports WGSL. Neither has happened yet.

Comment 8

[Gary [:streetwolf52]]

(In reply to Dzmitry Malyshau [:kvark] from comment #7)

You are enabling an experimental feature "dom.webgpu.enabled", which isn't providing any guarantees (yet).
This demo will work once 1) it's ported to WGSL, and 2) our implementation supports WGSL. Neither has happened yet.

Thanks for the info.

Comment 9

[Dzmitry Malyshau [:kvark]]

Should be closed once https://phabricator.services.mozilla.com/D107013 lands