1627541 - Move pref handling from SearchService to Region.jsm

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1627541 - Move pref handling into Region.jsm

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1627548 - Update Activity Stream to use new Region.jsm API

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d51495af14ff
Move pref handling into Region.jsm r=Standard8

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61e94240dbc7
Backed out changeset d51495af14ff for causing failures at test_legacy_reload_engines.js. CLOSED TREE

Comment 5

[Atila Butkovits]

Backed out for causing failures at test_legacy_reload_engines.js
https://hg.mozilla.org/integration/autoland/rev/61e94240dbc789ad4fa39d57ad815b8100159899

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=d51495af14ffe118a36d21c5d652bdcf6d4edc6d&selectedTaskRun=UPzeRdM7TEmvZYZH4ZIlsw-0

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303933946&repo=autoland&lineNumber=4702

Comment 6

[Dale Harvey (:daleharvey)]

So I was missing a switch to template string in the windows only telemetry code @ https://hg.mozilla.org/integration/autoland/rev/d51495af14ffe118a36d21c5d652bdcf6d4edc6d#l19.179, updated

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/396da163d87a
Move pref handling into Region.jsm r=Standard8

Comment 8

[Razvan Maries]

Backed out for perma failures on test_geodefaults.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=ZXi2bD1gSgmtRzt04-mL7Q-0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C7%2Cshippable%2Copt%2Cxpcshell%2Ctests%2Ctest-windows7-32-shippable%2Fopt-xpcshell-e10s-2%2Cx%28x2%29&revision=396da163d87a69fbe966302118e5091e1570caae

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303982398&repo=autoland&lineNumber=6991

Backout: https://hg.mozilla.org/integration/autoland/rev/467350d49e377fb463658c910916d4eeb918559c

Comment 9

[Dale Harvey (:daleharvey)]

test_geodefaults has an assumption that maybeReloadEngines wouldnt get triggered which this patch changed, it was timing dependent and quite surprising seems to only happen on windows reasonably often

Pushed fix to https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd07f17ca1aa74c5e900ae73a0af9bce915c3681 and will hopefully get it stick this time if that run is green

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6db34f17a6a8
Move pref handling into Region.jsm r=Standard8

Comment 13

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6db34f17a6a8

Comment 14

[Scott [:thecount] Downe]

Attachment: Bug 1627541 - Adding tests for region observer and region uninit

Comment 15

[Phabricator Automation]

Comment on attachment 9152069 [details]
Bug 1627548 - Update Activity Stream to use new Region.jsm API

Revision D77051 was moved to bug 1627548. Setting attachment 9152069 [details] to obsolete.

Comment 16

[Phabricator Automation]

Comment on attachment 9165532 [details]
Bug 1627541 - Adding tests for region observer and region uninit

Revision D84603 was moved to bug 1627548. Setting attachment 9165532 [details] to obsolete.