1615402 - Factor ImmutableScriptData fields out of ScriptStencil

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Jason Orendorff [:jorendorff]]

ScriptStencil has a set of fields that are redundant with stuff in ImmutableScriptData. The idea is, instead, for ImmutableScriptData to be a member of the stencil family of types.

Ownership: the field can be a UniquePtr<ImmutableScriptData>.

Comment 1

[Jason Orendorff [:jorendorff]]

Doing this causes JSScript::fullyInitFromStencil to consume the stencil, because it has to take ownership of the UniquePtr. The alternative would be something like Rust's Arc<T>.

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1615402 - Part 1: Change ImmutableScriptData::new_ to return UniquePtr. r?mgaudet

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1615402 - Part 2: Change JSScript::createImmutableScriptData to initImmutableScriptData. r?mgaudet

Depends on D63655

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1615402 - Part 3: Change ImmutableScriptData::XDR to not need friend access to JSScript. r?mgaudet

Depends on D63656

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1615402 - Part 4: Remove js::frontend::CGScopeNote. r?mgaudet

It is apparently completely unnecessary.

Depends on D63657

Comment 6

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1615402 - Part 5: Factor out an ImmutableScriptData from ScriptStencil. r?mgaudet

Depends on D63658

Comment 7

[Jason Orendorff [:jorendorff]]

I'm going to wait and land this after bug 1612515.

Comment 8

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1615402 - Part 6: Add field initializers to ScopeNote. r=mgaudet

Depends on D63659

Comment 9

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1615402 - Part 7: Update SmooshScriptStencil. r=arai

Depends on D66352

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de45fa761e5d
Part 1: Change ImmutableScriptData::new_ to return UniquePtr. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/f3173b7c223c
Part 2: Change JSScript::createImmutableScriptData to initImmutableScriptData. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/9c1fc73b9163
Part 3: Change ImmutableScriptData::XDR to not need friend access to JSScript. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/c4dc09959bed
Part 4: Remove js::frontend::CGScopeNote. r=mgaudet

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c00b5eef4b78
Part 5: Factor out an ImmutableScriptData from ScriptStencil. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/24af972b7541
Part 6: Add field initializers to ScopeNote. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/67cc4f2b6248
Part 7: Update SmooshScriptStencil. r=arai

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/de45fa761e5d
https://hg.mozilla.org/mozilla-central/rev/f3173b7c223c
https://hg.mozilla.org/mozilla-central/rev/9c1fc73b9163
https://hg.mozilla.org/mozilla-central/rev/c4dc09959bed
https://hg.mozilla.org/mozilla-central/rev/c00b5eef4b78
https://hg.mozilla.org/mozilla-central/rev/24af972b7541
https://hg.mozilla.org/mozilla-central/rev/67cc4f2b6248