1615934 - Send tab ID with compose.onBeforeSend and composeAction.onClicked events

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Geoff Lankow (:darktrojan)]

Given the difficulties (bug 1615926) of finding the currently active compose window, I think the events should give a reference to it. messageDisplay.onMessageDisplayed and messageDisplayAction.onClicked already do this. This would be a breaking change for compose.onBeforeSend, but that has only just reached beta.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1615934-onbeforesend-tabid-1.diff

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1615934-onclicked-tabid-1.diff

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9127194 [details] [diff] [review]
1615934-onbeforesend-tabid-1.diff

Review of attachment 9127194 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2996d7ac481a
Send tab ID with compose.onBeforeSend event. r=mkmelin
https://hg.mozilla.org/comm-central/rev/80f6ca1e8ac7
Send tab ID with composeAction.onClicked event. r=mkmelin

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9127194 [details] [diff] [review]
1615934-onbeforesend-tabid-1.diff

We should get this on beta before it becomes too well used.

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 74.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/685223c79e78
Thunderbird 74.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/f08f6af8f30b