1617514 - Action events should give whole tab objects, not just tab IDs

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Geoff Lankow (:darktrojan)]

+++ This bug was initially created as a clone of Bug #1615934 +++

Ugh, I've done this all wrong. :-(

According to MDN, the WebExtensions browserCompose onclicked event has always had a tab object argument and recently gained an OnClickData argument. Ours has neither.

Worse, our very similar messageDisplayAction has just an integer tab id (not the full object) and composeAction just gained the same. I think we should just fix them all, and compose.onBeforeSend. Only messageDisplayAction has this on 68, and AFAICT the usage is minimal to none.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1617514-tab-info-not-tab-id-1.diff

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9128433 [details] [diff] [review]
1617514-tab-info-not-tab-id-1.diff

Review of attachment 9128433 [details] [diff] [review]:
-----------------------------------------------------------------

Seems useful. r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9128433 [details] [diff] [review]
1617514-tab-info-not-tab-id-1.diff

We should probably put this on beta to avoid another round of churn. Bug 1615934 is new there for the upcoming beta2.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a144a25e5191
Give tab info and click info to *Action API events. r=mkmelin

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 74.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/181293f406d7