[Thunderbird Telemetry] collect number of address books + types + number of contacts
Categories
(Thunderbird :: Address Book, task)
Tracking
(thunderbird78+ fixed)
People
(Reporter: mkmelin, Assigned: rnons)
References
Details
Attachments
(1 file, 6 obsolete files)
7.57 KB,
patch
|
rnons
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
It would be useful to understand the design boundaries for address books. How many address books do people have, of what type, and how many contacts do they have [not for ldap].
Reporter | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Collect address book count and contact count, keyed by address book type.
The address book type can be 0, 2 or 101, do we want to convert it to string?
Reporter | ||
Comment 3•4 years ago
|
||
Comment on attachment 9154107 [details] [diff] [review] 1615986.patch Review of attachment 9154107 [details] [diff] [review]: ----------------------------------------------------------------- We probably need to hook this up somewhere else. Many people might not ever open the address book tab, but still use their address books. ::: mail/components/addrbook/content/abTrees.js @@ +174,5 @@ > + */ > +function reportAddressBook(directories) { > + let report = {}; > + for (let dir of directories) { > + let type = dir.dirType; Maybe it would be better to add a more selfexplanatory key. Like using the uri scheme, e.g. jscarddav, jsaddrbook, moz-abmdbdirectory, ldap, ldaps
Assignee | ||
Comment 4•4 years ago
|
||
- Moved the probe to msgMail3PaneWindow.js, so that it will run on TB starts.
- Used the URI scheme as address book type.
Assignee | ||
Comment 5•4 years ago
|
||
Remove a commented line.
Reporter | ||
Comment 6•4 years ago
|
||
Comment on attachment 9154840 [details] [diff] [review] 1615986.patch Review of attachment 9154840 [details] [diff] [review]: ----------------------------------------------------------------- LGTM ::: mail/base/content/msgMail3PaneWindow.js @@ +805,5 @@ > +function reportAddressBookTypes() { > + let report = {}; > + for (let dir of MailServices.ab.directories) { > + let index = dir.URI.indexOf(":"); > + let type = dir.URI.slice(0, index); maybe easier to just do let type = dir.URI.split(":")[0]; ::: mail/components/telemetry/Scalars.yaml @@ +150,5 @@ > +tb.addressbook: > + addressbook_count: > + bug_numbers: > + - 1615986 > + description: How many addressbooks were set up, keyed by addressbook type. Let's clarify that the type is the directory URI scheme.
Assignee | ||
Comment 7•4 years ago
|
||
- Changed to use split(":")[0]
- Updated scalar probe description
Assignee | ||
Updated•4 years ago
|
Reporter | ||
Comment 8•4 years ago
|
||
Somehow the attached patch is mangled and can't be applied. Please try exporting and uploading it again.
Assignee | ||
Comment 9•4 years ago
|
||
Rebased, should work now.
Assignee | ||
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/813ca5b455a8
Collect statistics of addressbooks and contacts. r=mkmelin
Reporter | ||
Comment 11•4 years ago
|
||
Sorry had to back this out due to test failures - backout: https://hg.mozilla.org/comm-central/rev/d4c0fe8b3368616586331c15efca65594e206c5d
E.g. https://treeherder.mozilla.org/#/jobs?repo=comm-central&selectedTaskRun=LL_HQ90mTn6cxnTTiYEe-w-0
Assignee | ||
Comment 12•4 years ago
|
||
Sorry, forgot to push to Try. Tests should pass now https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0073a1be8fda7c6b6913806f3d6a52f84dc1&selectedTaskRun=afp2hTK0QjGvAtu9OO9qjA-0
Assignee | ||
Updated•4 years ago
|
Reporter | ||
Comment 13•4 years ago
|
||
Comment on attachment 9155835 [details] [diff] [review] 1615986.patch Review of attachment 9155835 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/test/browser/addrbook/browser_addressBook.js @@ +401,5 @@ > + delete_address_book(addrBook1); > + delete_address_book(addrBook2); > + delete_address_book(addrBook3); > + delete_address_book(addrBook4); > + delete_address_book(ldapBook); I think these belong in the registerCleanupFunction instead. r=mkmelin with that fixed
Assignee | ||
Comment 14•4 years ago
|
||
Changed to use registerCleanupFunction
.
Assignee | ||
Updated•4 years ago
|
Comment 15•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/f5437b1e2765
Collect statistics of addressbooks and contacts. r=mkmelin DONTBUILD
Reporter | ||
Comment 16•4 years ago
|
||
Comment on attachment 9155882 [details] [diff] [review] 1615986.patch Telemetry addition - not risky.
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Comment 17•4 years ago
|
||
Comment on attachment 9155882 [details] [diff] [review] 1615986.patch Approved for beta
Comment 18•4 years ago
|
||
bugherder uplift |
Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/c19b6d0fdf3a
Updated•4 years ago
|
Description
•