1617013 - Have FunctionBox store and manipulate ImmutableScriptFlags

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

After 1615729 we will have extracted ImmutableScriptFlags for sharing with other consumers.

We should do the same for BaseScript::MutableFlags, and then change the internal representation of all the FnctionBox flags that are representable with these flag words to use them. Then we'll be able to get rid of ugly synchronization code like this which is error prone.

This also unlocks the ability more easily stuff these flags into stencils to allow deferred allocation.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Resummarying this bug a bit for now: It turns out that in the short term we only need the Immutable flags for FunctionBox. I do think that we need a MutableFlags later, but today we don't yet need that.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1617013 - Convert SharedContext to use immutable flags r?tcampbell

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1617013 - Unify setting of IsLikelyConstructorWrapper with other immutable flags r?tcampbell

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1617013 - Make ImmutableFlag managment flow through compilation better r?tcampbell

Depends on D64454

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36699203e990
Convert SharedContext to use immutable flags r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/0a0f348bf3ca
Make ImmutableFlag managment flow through compilation better r=tcampbell

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/36699203e990
https://hg.mozilla.org/mozilla-central/rev/0a0f348bf3ca