1617208 - Remove the ifdefs for about:profiling

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task, P2)

Description

[Greg Tatum [:gregtatum]]

This bug is to track the removal of the ifdefs around about:profiling. I still need to verify that no workflows will be interrupted. We'll ship about:profiling to all channels, but we won't migrate our existing addon users quite yet to the new workflow. This bug will NOT remove the ifdefs for the popup being available in the menu to a broader audience. That is Bug 1603242. However, users will be able to visit about:profiling across multiple channels now.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1617208 - Make about:profiling available everywhere by removing ifdef; r?julienw

This enables about:profiling everywhere, and removes the ifdefs. I can confirm that it
does not break things on a full Beta simulation in my manual tests. The DevTools panel
cannot be enabled. The popup cannot be enabled either.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2181d8a99229
Make about:profiling available everywhere by removing ifdef; r=julienw

Comment 3

[Arthur Iakab [arthur_iakab]]

Backed out 6 changesets (bug 1144438, bug 1617208, bug 1597378) for causing mochitest failures on test_perf-settings-entries.html.

Backout revision Backed out 6 changesets (bug 1144438, bug 1617208, bug 1597378) for causing mochitest failures on test_perf-settings-entries.html.

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=2181d8a99229269677715ef8b20b7d3860667004&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-macosx1014-64%2Fdebug-mochitest-chrome-1proc-1%2Cm-1proc%28c1%29

Failures https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=290405620&fromchange=2181d8a99229269677715ef8b20b7d3860667004&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-macosx1014-64%2Fdebug-mochitest-chrome-1proc-1%2Cm-1proc%28c1%29

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=290411296&repo=autoland

Greg can you please take a look?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eef173a3678d
Make about:profiling available everywhere by removing ifdef; r=julienw

Comment 5

[Arthur Iakab [arthur_iakab]]

Backed out 6 changesets (bug 1144438, bug 1617208, bug 1597378) for causing devtools failures on browser_all_files_referenced.js

Backout revision https://hg.mozilla.org/integration/autoland/rev/1c55bc6e995ada5e4b6a61f0ab0ce325a5988692

Failures https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cshippable%2Copt%2Cmochitests%2Ctest-linux1804-64-shippable%2Fopt-mochitest-devtools-chrome-e10s-1%2Cm%28dt1%29&fromchange=73d1a5e103376d0baba223a48ef1e1977d408043

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cshippable%2Copt%2Cmochitests%2Ctest-linux1804-64-shippable%2Fopt-mochitest-devtools-chrome-e10s-1%2Cm%28dt1%29&revision=eef173a3678d6b219ba25f583434621c7b883463

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=290471398&repo=autoland

Greg can you please take a look?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37df598adc9a
Make about:profiling available everywhere by removing ifdef; r=julienw

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/37df598adc9a