1618013 - Enable backdrop-filter by default when WebRender is enabled

Status: RESOLVED DUPLICATE of bug 1578503

(Core :: Graphics: WebRender, task, P2)

Description

[Sean Voisen (:svoisen)]

Whenever gfx.webrender.all is enabled, we should set layout.css.backdrop-filter.enabled to true. This will allow us to roll out backdrop-filter support to all systems that have WebRender turned on.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1618013 - Make BackdropFilter's Availability Depend on WebRender r=emilio

• Enable BackdropFilter pref by default
• Add function IsBackdropFilterAavailable()
• Use IsBackdropFilterAvailable for relevant WebIDL instead of pref
• Add test for BackdropFilter availability

Comment 2

[Sean Voisen (:svoisen)]

Now that we triage by severity, setting priority to P1 to reflect backlog prioritization on this bug as either in-progress, or planned development in the near term. See https://wiki.mozilla.org/Platform/Layout#Backlog_Tracking_in_Bugzilla

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1618013 - Enable backdrop-filter for early beta r=emilio

Resolution from intent-to-ship discussion is to release for early beta or earlier.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7549c5a5df5a
Enable backdrop-filter for early beta r=emilio

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for wr failures on will-change-abspos-cb-003.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/69b98c6f37a2137bf8ee85989719542026fcd9fb
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307190815&repo=autoland&lineNumber=14942

Comment 6

[Erik Nordin [:nordzilla]]

This failed due to an unexpected pass on will-change-absbos-cb-003.html.

I had a prior patch which was intended to update all of the test expectations:
https://phabricator.services.mozilla.com/D74162

I apologize. I'm not sure how this one test slipped through the cracks.

I've updated the expectation for this test to only fail if not webrender.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb9029d07271
Enable backdrop-filter for early beta r=emilio

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for wr failures on will-change-fixedpos-cb-005.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/b5d100345f40b193f23f308a33c689f7bad078f7
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307493634&repo=autoland&lineNumber=8217

Comment 9

[Erik Nordin [:nordzilla]]

NarcisB, sorry to cause you this trouble twice in a row.

I'm going to keep looking into this. Some of these WPTs seem like they may be inconsistent. I'm noticing some local failures on my macOS machine that are not showing up in your logs, and I also don't see what you reported in my pushes to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9cb3cc5bd229212721a4888f9ea5264d6e565eb&selectedTaskRun=Ji655y0bSu-ntYb2Fd-GCw.0

Anyhow, given the recent bug that darkspirit reported, I'm going to hold off on trying to land this until I can investigate further. And I certainly don't want to land during code freeze.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nordzilla, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 11

[Erik Nordin [:nordzilla]]

This patch was backed out twice due to some failing WPTs and a newly reported bug. Thankfully, this patch itself is a one-line change to the default value of a preference and shouldn't be subject to bit rot. At the time, we were approaching code freeze, and I didn't feel comfortable landing with these issues popping up.

I still have to look into the cause of the WPT failures before I can consider flipping the preference again.

Comment 12

[Tom S. (please needinfo tschuster)]

Erik what is the status of this bug? This keeps getting brought up in various discussions on the web. WebRender seems to be more widely rolled out now.

Comment 13

[Erik Nordin [:nordzilla]]

Hi Tom,

I was tasked with reworking our preferences so that backdrop-filter could be dependent on WebRender. That is, only available to be enabled if WebRender is enabled at the pref level.

This bug characterizes a small patch that would turn on backdrop-filter by default if WebRender is enabled.

Unfortunately, when I tried to land this patch, it was backed out due to some failing WPTs involving backdrop-filter itself.

So the current status is that we need to look into the tests that failed, and potentially tweak the backdrop-filter implementation to pass the tests.

I had a loose goal to try to look into this myself, but I never got around to it due to work on the new print UI. I don't have any experience with the actual backdrop-filter implementation itself: I only worked on the prefs, so this will require some amount of ramping up on this domain for me. I'm also open to someone else looking into the actual backdrop-filter implementation.

The pref work is all landed, just waiting on the switch to be flipped to on by default (which is what this patch does).

Is there a sense of priority for this feature now that WebRender is more established?

Comment 14

[Tom S. (please needinfo tschuster)]

I don't have any experience with the actual backdrop-filter implementation itself

Sounds like somebody from the graphics team should look into this.

Is there a sense of priority for this feature now that WebRender is more established?

Well I obviously can't speak for the WebRender people. My though was that now that we use WebRender a lot more enabling this is going to have a larger impact. It doesn't seem like this has a high priority though.

Comment 15

[roberto_minhoto]

Hello! There is any ideia when this will be fixed? Is having a great impact in some web app that my team is working on.
Firefox is the only browser with this problem. We don't want to limit firefox use to our dozens of million users.
An answer would be very appreciated, Thanks!

Comment 16

[Sebastian Zartner [:sebo]]

I guess Erik already provided all the info he could in comment 13.

And from what I get from his and Tom's comment is that the WebRender team needs to prioritize this. In the hope that it's the right way to do that, I've now set this to block bug 1632611. Erik, Tom, if that's not the right way to do that, maybe you could need-info someone of that team instead.
Looking at the dependency list of bug 1578503 though, it seems there still need to be some bugs fixed before this feature can be shipped.

Sebastian

Comment 17

[Andrew Osmond [:aosmond] (he/him)]

Let's take a closer look at these failures. Updated try with it turned on: https://treeherder.mozilla.org/#/jobs?repo=try&revision=96e82c89e4cf953f27b6c0268e5a8ddfc830f9b4

Comment 18

[Jim Mathies [:jimm]]

This can wait for Q3 once wr hits 100%. The old pipelines don't support it.

Comment 20

[Emilio Cobos Álvarez [:emilio]]

I guess now we're WR only we can do this.