Closed Bug 1618841 Opened 4 years ago Closed 3 years ago

[cleanup] Fluent translations stored in database without the trailing newline

Categories

(Webtools Graveyard :: Pontoon, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED MOVED

People

(Reporter: adrian, Unassigned)

References

Details

It seems that some Fluent messages are stored in the translation table without the usual trailing newlines. That leads to comparison problems in the code, where translations are considered different because the one coming from the database lacks the newline character.

This bug covers figuring out why and where the newline character gets dropped, and fixing the issue.

Note that the Translate app correctly sends Fluent translations with the trailing newline.

It turns out this bug got fixed along with bug 1632206 on Aug 6, 2020.
It was introduced exactly 6 months earlier on Feb 6, 2020 when bug 1527853 got fixed.

The most obvious consequence of this bug was that submitted FTL strings got re-imported with trailing newlines after subsequent sync (see bug 1650642). So there's a lot of FTL translations submitted within this 6-month time period we need to clean up.

I'm re-purposing this bug to find such translation pairs, fix attribution on imported translations and delete translations without trailing newlines.

Summary: Fluent translations stored in database without the trailing newline → [cleanup] Fluent translations stored in database without the trailing newline

Side note: this is still happening, I think when old suggestions (pre-fix) are approved. So, we also need to clean up at unreviewed suggestions?

*This bug has been moved to GitHub.*

*Please check it out on https://github.com/mozilla/pontoon/issues.*
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → MOVED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.