1619030 - Re-enable the "Change to existing username, different password" test in browser_doorhanger_form_password_edit.js" test

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P3)

Description

[Sam Foster [:sfoster] (he/him)]

The "Change to existing username, different password" test was intermittent when attempting to land bug 7f3012de280f. I disabled it for later investigation.

TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_doorhanger_form_password_edit.js | Message not sent - 
Stack trace:
chrome://mochikit/content/browser-test.js:test_ok:1292
chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_doorhanger_form_password_edit.js:testPasswordChange/<:303
resource://testing-common/BrowserTestUtils.jsm:withNewTab:150
chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_doorhanger_form_password_edit.js:testPasswordChange:271
chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_doorhanger_form_password_edit.js:Change to existing username, different password:242
chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
chrome://mochikit/content/browser-test.js:Tester_execTest:1097
chrome://mochikit/content/browser-test.js:nextTest/<:919
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:914

I think, somehow it gets into a state where an identical PasswordEditedOrGenerated message has already been sent:

GECKO(27454) | console.log: LoginManagerChild: "_compareAndUpdatePreviouslySentValues: values are equivalent, returning true"
GECKO(27454) | console.log: LoginManagerChild: "{\"username\":\"user-saved\",\"password\":\"pass1\",\"dismissed\":true,\"triggeredByFillingGenerated\":false}"

Comment 1

[Matthew N. [:MattN]]

Check if this is fixed.

Comment 2

[Sam Foster [:sfoster] (he/him)]

This is looking promising: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfe532221543011a4bae4f70131028c6c62cd181
The underlying cause was fixed in bug 1620482, if that sticks, I'll land this one too.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1619030 - Re-enable the Change to existing username, different password test. r?MattN

Comment 4

[Sam Foster [:sfoster] (he/him)]

This test is providing coverage for the dismissed-doorhanger-on-edit behavior so while it should run and pass without bug 1618696, there's no rush to land it until the pref is enabled by default.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/679f8625b6ba
Re-enable the Change to existing username, different password test. r=MattN

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/679f8625b6ba