1619110 - Apply Picture-in-Picture toggle policy to more Udemy domains

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

See bug 1606195 comment 8.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1619110 - Apply Picture-in-Picture toggle policy to more Udemy domains. r?mstriemer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1249994ab28
Apply Picture-in-Picture toggle policy to more Udemy domains. r=denschub

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9130141 [details]
Bug 1619110 - Apply Picture-in-Picture toggle policy to more Udemy domains. r?mstriemer

Beta/Release Uplift Approval Request

• User impact if declined: Some videos on Udemy domains will still see the Picture-in-Picture toggle intersect the "next" video carousel button.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is adjusting the Picture-in-Picture toggle policy for Udemy to include more subdomains. It's a very well encapsulated and well-understood patch.
• String changes made/needed: None.

Comment 4

[Pascal Chevrel:pascalc]

Comment on attachment 9130141 [details]
Bug 1619110 - Apply Picture-in-Picture toggle policy to more Udemy domains. r?mstriemer

Looks very safe, approved for beta before the merge.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c35155430ed0

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a1249994ab28