1619547 - Redirect Search tips (google.com) are flicker displayed

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: redirect.mp4

[Environment:]

Windows 10, Mac 10.15.3, Ubuntu 18.04
Firefox Nightly 75.0a1 20200302212732
Firefox 74.0b9 (enabling browser.urlbar.update1.searchTips & browser.urlbar.update1)

[Preconditions:]

1. Create a new profile.
2. Verify that no updates have been made in the last 24h (open about:support, update folder , open folder and delete update.xml if any is listed)
3. Set profile age to be older by running the following snippet in browser console: (async function() { let { ProfileAge } = ChromeUtils.import("resource://gre/modules/ProfileAge.jsm"); let age = await ProfileAge(); age._times = { firstUse: 1368255600000, created: 1368255600000 }; await age.writeTimes(); })();
4. Restart browser with restore session and a random youtube.com/video loaded
5. Default search is google.com.

[Steps:]

1. Browser is opened with your custom youtube link restored.
2. Focus address bar and type google.com

[Actual Result:]

Redirect search tips are displayed and imediately auto-dismissed.

[Expected Result:]

Redirect search tips are displayed upon redirecting to any of the google.com homepages.

[Note:]

Using the "cheat" preference browser.urlbar.searchTips.test.ignoreShowLimits to true will not reproduce the issue.

Comment 1

[Adrian Florinescu [:aflorinescu]]

On further testing, this issue only reproduces with google.com: updating title to properly reflect this.

When bing.com or duckduckgo.com are set as default engines, the Search Tips are properly displayed with comment 0 scenario.

Comment 2

[Harry Twyford]

The issue here is that my assumption in bug 1613662 comment 2 was wrong. We encounter two onLocationChange events when navigating to the Google homepage. The second one hits this check, which closes the view containing the Search Tip. To resolve this issue, we could reintroduce a timeout on UrlbarProviderSearchTip's search call , but that would just reintroduce bug 1613662. We also can't remove the view.close call since it's what prevents the Search Tip from staying open after the user navigates to the Google results page.

We need to balance showing the Search Tip quickly, to combat bug 1613662; and accounting for multiple onLocationChange calls. I'll think on this.

Comment 3

[Harry Twyford]

Attachment: Bug 1619547 - Check if the user is typing a query before showing a Search Tip. r?adw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1863553d41b3
Check if the user is typing a query before showing a Search Tip. r=adw

Comment 5

[Harry Twyford]

Attachment: Bug 1619547 - Hotfix - Move forgotten urlbar/tests/browser skip-ifs. r?adw!

Comment 6

[Phabricator Automation]

Comment on attachment 9130848 [details]
Bug 1619547 - Hotfix - Move forgotten urlbar/tests/browser skip-ifs. r?adw!

Revision D65372 was moved to bug 1618867. Setting attachment 9130848 [details] to obsolete.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1863553d41b3