Closed Bug 1619576 Opened 5 years ago Closed 5 years ago

image with bogus EXIF orientation data is shown incorrectly

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect, P2)

defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- unaffected
firefox74 --- unaffected
firefox75 --- fixed
firefox76 + wontfix
firefox77 + wontfix

People

(Reporter: andrew, Assigned: heycam)

References

(Regression)

Details

(Keywords: regression)

Attachments

(5 files)

When viewing http://cardhouse.com/where/jejune.htm the first image is rotated 90 degrees counter-clockwise when viewed in Firefox desktop nightly and Firefox Android Preview nightly. However it is displayed correctly (text horizontal) in Firefox Android classic and Chrome.

Attachment #9130401 - Attachment description: Firefox Android classic nightly.jpg → Firefox Android Preview nightly.jpg
Attached image Chrome 80.jpg
Attached image one-microwave.jpg
Component: General → Layout: Images, Video, and HTML Frames
Product: Firefox → Core

Tested in 74 beta where things work correctly, so this seems to be a recent-ish regression - or a pref/config difference between beta and nightly.

This is the other way around, that image has bogus exif information. Chrome Canary also shows the same as Firefox.

This is a regression from bug 1607667. This is the second one and it's been on Nightly only for a couple weeks... Maybe we should reconsider?

Flags: needinfo?(cam)
Regressed by: 1607667
Has Regression Range: --- → yes
See Also: → 1616789
Priority: -- → P2

If this is indicative of some tooling or workflow (or perhaps digital camera output) that results in JPEGs with bogus EXIF information, then that would start to concern me. I'm inclined still to wait until beta, at which point Chrome's equivalent change will be rolled out to release, and we can assess then.

One interesting thing I noticed with this image is that the raw image data size (600x799) does not match the aspect ratio of the Image Width / Image Height EXIF tags (3648x2736). That's consistent with a tool that rotates the raw image data but doesn't touch any EXIF metadata. Same for Jens' image. The EXIF spec says these two tags are ignored because the image dimensions in JPEG markers are used instead. But if they are present, and their aspect ratio is the inverse of the raw image data size, and there is a rotation specified in the Orientation tag, maybe that's sufficient to identify images that will be shown "incorrectly"?

Flags: needinfo?(cam)
Summary: EXIF orientation not applied → image with bogus EXIF orientation data is shown incorrectly

Hi Cameron, do we have now a better understanding if we should act on our side?

Flags: needinfo?(cam)

IIUC, this was fixed by backout for Fx75. Given our desire to minimize potential breaking changes at the moment, I'm wondering if we should at a minimum restrict this change to Nightly only while we work out the kinks?

Flags: needinfo?(cam)

Assigning to heycam since he owns this project. Per comment 9 and comment 10, this will be held to Nightly for now.

Assignee: nobody → cam

[Tracking Requested - why for this release]:
bug 1623820 which was supposed to make the change nightly only got backed out from 76, so it's still affected. how are supposed to progress here?

Flags: needinfo?(cam)

Right, this is still WONTFIX per our current plan. Andrew, you can fix this for your site by adding img { image-orientation: none; } to your CSS.

If we eventually find there are too many of these broken images, we can think about how to ameliorate the problem by adding some heuristics. But for now, we're likely to just follow Chrome's choice in whether this change will stick.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(cam)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: