Closed Bug 161969 Opened 22 years ago Closed 21 years ago

Deleting quoted text keeps quote status

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

VERIFIED WORKSFORME
mozilla1.5alpha

People

(Reporter: 3.14, Assigned: mozeditor)

References

(Blocks 1 open bug)

Details

(Keywords: topembed+, Whiteboard: [EDITORBASE+] fixinhand)

Attachments

(1 file)

Spinoff from bug 133741, comment 12.

When you mark a paragraph and press delete, then immediately type something,
it is blue. It is not mailed as quote, though.

pi
*** Bug 159738 has been marked as a duplicate of this bug. ***
Whiteboard: [EDITORBASE]
-->jfrancis
Assignee: ducarroz → jfrancis
Keywords: mailtrack
EDITORBASE+.
Sounds like layout -> Kin
Assignee: jfrancis → kin
Whiteboard: [EDITORBASE] → [EDITORBASE+]
Steps- seen in trunk builds 20021119 on winxp, mac and linux.
1. Set your account to compose in plain text. (uncheck the html option in
account settings)
2. Open a plain or html text message and click reply, you will see the quoted
text in the default color of blue as well as the ">".  
3. Select all of the quoted text and ">", then delete or backspace over all the
text.
4. Start typing, the new text is in blue 

workaround: If you click <Enter> after deleting all the text, the newly typed
text will be black.
i bet one more backspace and it desn't happen.

After you backspace through the last character, you probably have a span with a
mailcite attribute on it, with a br insidde it.  So it's a blank line that is a
mailcite.  Once you start typing in it, it's still a mailcite.  Basically this
is working as designed.  I guess we could remove mailcites if they ever contain
nothing other than a br.  We would have to make sure to leave the br behind,
though, otherwise you wold see a line suddenly disappear as you deleted the last
character.

cc'ing a few smart friends for comments.
--> jfrancis
Assignee: kin → jfrancis
> I guess we could remove mailcites if they ever contain 
> nothing other than a br.  We would have to make sure to leave the br behind,

I agree that this is the right thing to do.  We definitely never want an
invisible mail cite (one containing only whitespace).
sorry one more back space doesn't give you a new line within mailquote, it wraps
to the end of the previous line.   <Enter> within mailquote is the only way to
get a new line.
Esther: I think you misunderstood me.  I was saying one more backspace will get
rid of the mailcite.  It also will bring you up to the previous line, true: but
you would expect that.  You are then free to type return to get back to next
line and then type, and I bet that won't be in a mailcite.

Akkana: note that in html mail the mailcite won't be invisible in this case,
since we use the blue bar.
Let me clarify. I reported this bug for plain text editor. I always use plain
text for some ten years now in mail and news. The idea of html in this context
is so completely absurd to me that I missed to mention that, sorry.

Having said that, it is extremly counterintuitive that a line which does not
start with a quotation symbol is treated as quote (actually, it is not a quote
after sending).

pi
editor:code
Component: Composition → Editor: Core
Product: MailNews → Browser
Target Milestone: --- → M1
This is related to 181898.  I need to do a couple of checks after deletion
regarding mailcites:
1) Have I emptied a mailcite?  If so delete the cite.
2) Did I delete across a boundary of a mailcite?  If so make sure selection ends
up outside cite.
Status: NEW → ASSIGNED
Did you intend to set the Target Milestone to M1?
Yes, Joe uses a different milestone system.  I would advise NOT changing it or
the bug won't appear on his radar.  :-)
tweaks deletion code to remove any empty mailcites created by deletion.
Whiteboard: [EDITORBASE+] → [EDITORBASE+] fixinhand
Attachment #112812 - Flags: superreview?(kin)
Attachment #112812 - Flags: review?(brade)
Comment on attachment 112812 [details] [diff] [review]
patch to editor/libeditor/html

r=brade
Attachment #112812 - Flags: review?(brade) → review+
Comment on attachment 112812 [details] [diff] [review]
patch to editor/libeditor/html

sr=kin@netscape.com
Attachment #112812 - Flags: superreview?(kin) → superreview+
EDITORBASE+ topembed+ normalization
Keywords: topembed+
fix landed on trunk
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030331

Still fails for me. To reproduce mark some lines in quoted text and press
delete. Start typing. It is blue.

pi
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Beth can you try to reproduce? 
QA Contact: esther → beppe
Target Milestone: M1 → mozilla1.5beta
Using the trunk build from 20030507:

1. opened mail
2. unchecked the Compose in HTML in my prefs
3. selected a message and selected reply
4. I highlighted from the left of the first blue greater than symbol (>) to the
right of the last (>) symbol.
5. Selected 'Delete'
6. Immediately started typing.

The text displayed in black, there was no indication of the text being within
the quote.

I checked the source by copy/paste into Composer and the underlying code was
also void of the quote.
this si weird, I went to test with today's trunk build and the mail utility is
not there
I cannot reproduce with 20030508 Linux/x86.

If I highlight every quoted line, i.e. all of every blue line, and then
immediately start typing, the new text is black.

If I highlight every quoted line, i.e. all of every blue line, and then press
delete, then start typing, the new text is black.
However, if I highlight only some of the blue lines within the quoted section,
and delete them (i.e. I don't delete all of them, just a chunk contained
entirely within the quote), then new text does appear in blue. That's what I
would expect though.
Target Milestone: mozilla1.5beta → mozilla1.5alpha
Resolving as WFM. Please open a new bug for any remaining issues.
Status: REOPENED → RESOLVED
Closed: 21 years ago21 years ago
Resolution: --- → WORKSFORME
v

pi
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: