1619851 - Login doorhanger telemetry counts impressions when updating/replacing a doorhanger for the same document

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P3)

Description

[Matthew N. [:MattN]]

• Each time the user edits a generated password I think we may count an impression.
• If we leave a page and prompt multiple overlapping prompts then we won't count both impressions even though the user only really saw one.

PWMGR_PROMPT_REMEMBER_ACTION and PWMGR_PROMPT_UPDATE_ACTION are affected.

We should also probably record dismissed doorhanger telemetry separate from non-dismissed as the engagement rate should be very different. To do this we may want to move to telemetry events.

Maybe this will be our excuse to refactor how our doorhangers work so that we actually have a way to update the contents without simply opening a new one which replaces the old (and causing this skewing).

Comment 1

[Matthew N. [:MattN]]

A small workaround would be to move the DISPLAYED accumulation to the "showing" callback of the doorhanger with a check of !this.timeShown (to ensure it was the first showing) so the meaning would change to only record "DISPLAYED" when the panel was first shown.

Comment 2

[Matthew N. [:MattN]]

Conveniently we still have the POPUP_NOTIFICATION_STATS histogram with the "password" key (combining save and update unfortunately) so we can see that the issue isn't huge: https://sql.telemetry.mozilla.org/queries/69323#174872 (Note there is also a slight discrepancy in the save+update counts between the different histgrams which I can't account for yet but it probably doesn't matter much)

It looks like a difference of only about 1% when combining the save and update prompts. It would still be good to fix this so we can more accurately watch save and update separately.

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1619851 - Only record in bucket 0 of PWMGR_PROMPT_*_ACTION when the prompt is actually displayed. r=sfoster,jaws

I didn't add an automated test as it's a trivial change without existing telemetry tests and I want to replace this histogram with event telemetry soon anyways.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb46efab2da8
Only record in bucket 0 of PWMGR_PROMPT_*_ACTION when the prompt is actually displayed. r=sfoster

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/bb46efab2da8