1620048 - "There are no downloads." text in about:downloads is pretty much unreadable - should use photon colours

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P3)

Description

[:Gijs (out for now; he/him)]

Tested on macOS nightly in case it matters.

The text is grey, and so is the background. The text is also tiny.

I have to assume this regressed at some point, it seems unlikely we shipped it with contrast this low.

Comment 1

[Gabi Cheta [:Gabi] Desktop QA]

Results from mozregression:
9:54.72 INFO: Got as far as we can go bisecting nightlies...
9:54.72 INFO: Last good revision: 8ec327de0ba7c25c185b887a57877657bda20d47 (2019-01-14)
9:54.72 INFO: First bad revision: 2bf2c209f520c75405b70ed5a5a12c2a8938dffe (2019-01-15)
9:54.72 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8ec327de0ba7c25c185b887a57877657bda20d47&tochange=2bf2c209f520c75405b70ed5a5a12c2a8938dffe

Comment 2

[:Gijs (out for now; he/him)]

This is a bit better on Windows, but we technically fail contrast checks there, too.

I also noticed that drag/drop on this text is supposed to work (bug 978291) but AFAICT drag/drop even to a populated downloads list box is also broken. I filed bug 1620184.

From the regression window, this looks like bug 1511878.

Comment 3

[:Gijs (out for now; he/him)]

Attachment: Screenshot 2020-03-05 at 13.41.48.png

Comment 4

[:Gijs (out for now; he/him)]

Looks like the colour should be var(--in-content-deemphasized-text).

Comment 5

[:Gijs (out for now; he/him)]

Attachment: Bug 1620048 - use photon de-emphasized text colour for about:downloads de-emphasized text, r?mak

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20e437df546f
use photon de-emphasized text colour for about:downloads de-emphasized text, r=mak

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/20e437df546f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Should this have a Beta uplift request?

Comment 9

[:Gijs (out for now; he/him)]

Comment on attachment 9132012 [details]
Bug 1620048 - use photon de-emphasized text colour for about:downloads de-emphasized text, r?mak

Beta/Release Uplift Approval Request

• User impact if declined: Unreadable text on macOS
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS change to make the foreground colour suck less
• String changes made/needed: nope

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9132012 [details]
Bug 1620048 - use photon de-emphasized text colour for about:downloads de-emphasized text, r?mak

Low risk css change, uplift approved for 75 beta 6, thanks!

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/87d6989489c7

Comment 12

[Raluca Popovici, Desktop QA]

Reproduced the initial issue in Release version 74 using Windows 10.
Verified - Fixed in latest Nightly build 76.0a1 and Firefox Beta 75.0b7 using Windows 10 and MacOS 10.15.