1620236 - Comments on submitted bugs are re-populated if user chooses to show next bug in my list after changing a bug

Status: NEW

(bugzilla.mozilla.org :: Bug Creation/Editing, defect)

Description

[Bob Clary [:bc] (inactive)]

It appears that bug 1599865 has caused submitted bug comments to remain in Local Storage and and to be used to fill the comment text area on revisiting or reloading a bug even after the comment has been submitted.

This is occurring for me with Nightly on Linux and is a major inconvenience.

Comment 1

[Kohei Yoshino [:kohei]]

Interesting. Does this happen every time? Has anyone encountered the issue since Bug 1599865 deployed to production last week?

Comment 2

[Kohei Yoshino [:kohei]]

I didn’t see any issue with the comment above. The comment field became empty after submission.

Comment 3

[Kohei Yoshino [:kohei]]

And I think the relevant bug is Bug 1472757. The New Bug page isn’t using local storage yet.

Comment 4

[Kohei Yoshino [:kohei]]

Came up with a scenario: If you have changed the After changing a bug preference from Show the updated bug to Show next bug in my list, the local storage won’t be cleared. Not sure if this applies to Bob’s case though.

Comment 5

[Bob Clary [:bc] (inactive)]

I see it every time. I do have show next bug in my list set. I just changed it to show the updated bug. Let's see if it worked!

Comment 6

[Bob Clary [:bc] (inactive)]

I do not see the comment pre-populated.

Comment 7

[Kohei Yoshino [:kohei]]

Thanks for testing! I’ll figure out how to work around the “next bug” issue.

Comment 8

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request

Simple fix.

Comment 9

[David Lawrence [:dkl]]

Merged to master.

Comment 10

[Bob Clary [:bc] (inactive)]

Changed my pref back to show next bug in list...

Comment 11

[Bob Clary [:bc] (inactive)]

Really changing my pref...

Comment 12

[Bob Clary [:bc] (inactive)]

I'm sorry. I thought this had been deployed. I'll wait for bmo push day to verify.

Comment 13

[Bob Clary [:bc] (inactive)]

And now it has...

Comment 14

[Bob Clary [:bc] (inactive)]

kohei: I just saw the bmo push day notice, changed my pref back, reloaded the page and still see the comment populated after visiting the bug again. Am I just early or is this not fixed?

Comment 15

[Kohei Yoshino [:kohei]]

I just tested with Bug 1614329 and the comment cache was cleared properly. But if you simply navigate back to the previous page after changing a bug, the comment field may still have your posted comment because of the browser’s back-forward cache. Not sure if we can avoid this behaviour.

Comment 16

[Bob Clary [:bc] (inactive)]

I don't think this was the bf cache. If I recall correctly it was clicking on the link to the bug after it was updated and not using the back button. I just switched the pref and reloaded and will confirm after I post this comment.

Comment 17

[Bob Clary [:bc] (inactive)]

I don't think this was the bf cache. If I recall correctly it was clicking on the link to the bug after it was updated and not using the back button. I just switched the pref and reloaded and will confirm after I post this comment.

I can confirm I see the same comment already in the input after clicking the link to the updated bug. I'll do this comment and then check local storage to see if the comment is still there before I click the link.

Comment 18

[Bob Clary [:bc] (inactive)]

The local storage still contained the previous comment. The storage is continually updated as I type this.

Comment 19

[Bob Clary [:bc] (inactive)]

Clicking save did not delete the local storage. This is not fixed. Remember you need to set the "After changing a bug" to "Show next bug in my list".

Comment 20

[Kohei Yoshino [:kohei]]

Would you mind taking a screencast?

Comment 21

[Bob Clary [:bc] (inactive)]

I don't really have any screencasting software installed. I'll walk through the steps to reproduce on Fedora 31 using Nightly 76.0a1.

1. Click my avator in the top right corner.
2. Middle click Preferences to load it in a new tab.
3. Click General Preferences
4. Change After changing a bug to Show next bug in my list.
5. Scroll down and click Submit Changes.
6. Open Web Developer Storage Inspector
7. Note no comments saved.
8. Click Save Changes.

Comment 22

[Bob Clary [:bc] (inactive)]

Attachment: Screenshot from 2020-03-11 19-16-26.png

Comment 23

[Kevin Brosnan [Ex-Mozilla]]

This is really frustrating. I have submitted a few duplicate comments recently because of this bug. I have changed the pref back to the default to see if that fixes the problem.