Closed Bug 1472757 Opened 6 years ago Closed 5 years ago

Comment field empty after clicking "go back page"

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: wsmwk, Assigned: kohei)

References

(Regressed 1 open bug)

Details

(Keywords: bmo-ux, dataloss, Whiteboard: [october-2019-bmo-triage])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
Details | Review
+++ This bug was initially created as a clone of Bug #1469023 +++ (I assume this is a regression of bug 1469023) I made a change and clicked "Save changes", which conflicted with someone else's intervening update. I clicked "go back page" in the browser and expected to find my uncommitted changes in the comment field. The comment field was blank.
Assignee: nobody → dylan

This is not a regression but due to the design of the comment saving functionality, which clears your saved comment as soon as the Save Changes button is clicked. It should take mid-air collisions into account.

Keywords: regression
Assignee: dylan → nobody

The cached comment should be deleted once the bug is saved successfully, not once the Save Changes button is pressed. I’ll try to fix this once Bug 1556727 is landed, which will be an indicator of whether the bug was saved or simply loaded.

Depends on: 1556727
Assignee: nobody → kohei.yoshino
Keywords: dataloss
See Also: → 1576149
Assignee: kohei.yoshino → nobody
Component: User Interface: Modal → User Interface

This wasn’t actually blocked by Bug 1556727. PR coming.

Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
No longer depends on: 1556727
Attached file GitHub Pull Request
Regressions: 1620236

Already merged and deployed to production.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: