Closed Bug 1620438 Opened 5 months ago Closed 3 months ago

Remove references to extensions.webservice.discoverURL

Categories

(Toolkit :: Add-ons Manager, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mstriemer, Assigned: gaurijove)

References

Details

Attachments

(1 file)

Bug 1544011 removed the last place we checked the extensions.webservice.discoverURL pref, but it was already not doing anything.

All references to this pref can be removed now. The const defined in head.js leads to browser_history_navigation.js. That file can have the MAIN_URL const removed along with the url argument from the is_in_discover helper.

https://searchfox.org/mozilla-central/search?q=extensions.webservice.discoverURL

This is not some trivial removal, some attention must be paid to the CSP directives. I'll take over this bug since I know the context of these.

Assignee: mstriemer → rob
Duplicate of this bug: 1630650

Mark, what is the last Firefox release which actually handled that preference? I'm asking in regards of the Marionette changes in the patch given that we have to keep some backward compatibility for geckodriver and older Firefox releases. Currently our minimum version of Firefox, which we support, is 60.0ESR.

Flags: needinfo?(mstriemer)

I think 68 would've been the first version that didn't use it by default, but it was probably still supported by flipping some prefs at that point. I guess when Thunderbird had to change, Rob? Do you recall when that happened?

Flags: needinfo?(mstriemer) → needinfo?(rob)

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #4)

Mark, what is the last Firefox release which actually handled that preference?

  • Firefox 73 removed support for the feature (bug 1337627).
  • Firefox 69 stopped using the feature by default (bug 1555012).

I'm asking in regards of the Marionette changes in the patch given that we have to keep some backward compatibility for geckodriver and older Firefox releases. Currently our minimum version of Firefox, which we support, is 60.0ESR.

To prevent about:addons from triggering network activity, extensions.getAddons.discovery.api_url should be set, e.g. to data:, (an empty data:-URL).

Flags: needinfo?(rob)

Thanks Rob! Note that we won't need that fallback for Puppeteer and Marionette/geckodriver by default. Puppeteer and geckodriver are targeted for content related automation purposes, and Marionette lives in-tree and right now we don't have tests that open about:addons.

Would you rather remove the pref or keep the new pref?

The current version of the patch has the correct preference (to disable network activity on about:addons).

It's ok to keep the pref for now given that it doesn't hurt us and gives less risk for side-effects. We can check later to remove it ourselves.

I tried to land the patch, but got the following:
Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

applying /tmp/tmpXw2sSL
toolkit/mozapps/extensions/test/browser/browser_history_navigation.js
Hunk #1 FAILED at 18.
1 out of 6 hunks FAILED -- saving rejects to file toolkit/mozapps/extensions/test/browser/browser_history_navigation.js.rej
abort: patch command failed: exited with status 256

Jayati, please see the last comment. Your patch needs to be rebased against central. Thanks.

Assignee: rob → gaurijove
Status: NEW → ASSIGNED
Flags: needinfo?(gaurijove)

Patch rebased :)

Flags: needinfo?(gaurijove)
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/03da091fad18
Remove references to extensions.webservice.discoverURL. r=robwu,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,whimboo,sparky
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.