1620582 - aboutwelcome.css has changes after npm run bundle

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Kate Hudson :k88hudson]

Right now there are changes to this file when running npm run bundle:

diff --git a/browser/components/newtab/aboutwelcome/content/aboutwelcome.css b/browser/components/newtab/aboutwelcome/content/aboutwelcome.css
index 74953be4dfe0..121795c9b396 100644
--- a/browser/components/newtab/aboutwelcome/content/aboutwelcome.css
+++ b/browser/components/newtab/aboutwelcome/content/aboutwelcome.css
@@ -49,7 +49,6 @@ body {
   background-color: var(--trailhead-cards-background-color);
   font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', 'Ubuntu', 'Helvetica Neue', sans-serif;
   font-size: 16px;
-  min-height: 100vh;
   position: relative; }

 .trailheadCardGrid {

Comment 1

[Kate Hudson :k88hudson]

It looks like maybe this change was intentional but didn't make it into the scss source files?

:emcminn can you resolve this today before the merge?

Comment 2

[Emily McMinn :emcminn]

I've added the fix for this into https://phabricator.services.mozilla.com/D65646 since that's already queued to land; once we've verified that it's landed successfully I'll update this bug :)

Comment 3

[Emily McMinn :emcminn]

https://phabricator.services.mozilla.com/D65646 successfully landed, so this will now be fixed.