Closed Bug 1620582 Opened 5 years ago Closed 5 years ago

aboutwelcome.css has changes after npm run bundle

Categories

(Firefox :: Messaging System, defect, P1)

Product:
Firefox
Component:
Messaging System
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 75
Iteration:
75.2 - Feb 24 - Mar 8
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: k88hudson, Assigned: emcminn)

References

(Regression)

Details

(Keywords: regression)

Right now there are changes to this file when running npm run bundle:

diff --git a/browser/components/newtab/aboutwelcome/content/aboutwelcome.css b/browser/components/newtab/aboutwelcome/content/aboutwelcome.css
index 74953be4dfe0..121795c9b396 100644
--- a/browser/components/newtab/aboutwelcome/content/aboutwelcome.css
+++ b/browser/components/newtab/aboutwelcome/content/aboutwelcome.css
@@ -49,7 +49,6 @@ body {
   background-color: var(--trailhead-cards-background-color);
   font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', 'Ubuntu', 'Helvetica Neue', sans-serif;
   font-size: 16px;
-  min-height: 100vh;
   position: relative; }

 .trailheadCardGrid {
Regressed by: 1618348
Has Regression Range: --- → yes
Keywords: regression

It looks like maybe this change was intentional but didn't make it into the scss source files?

:emcminn can you resolve this today before the merge?

Assignee: nobody → emcminn
Flags: needinfo?(emcminn)
Priority: -- → P1
Iteration: --- → 75.2 - Feb 24 - Mar 8
status-firefox75: --- → affected
Blocks: simple-aw

I've added the fix for this into https://phabricator.services.mozilla.com/D65646 since that's already queued to land; once we've verified that it's landed successfully I'll update this bug :)

Flags: needinfo?(emcminn)

https://phabricator.services.mozilla.com/D65646 successfully landed, so this will now be fixed.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
status-firefox75: affected → fixed
Depends on: 1620258
Target Milestone: --- → Firefox 75
You need to log in before you can comment on or make changes to this bug.