Closed Bug 1620861 Opened 5 months ago Closed 5 months ago

Thunderbird is not prompting for updates to WebExtensions when there are new permissions

Categories

(Thunderbird :: Add-Ons: General, defect, P1)

defect

Tracking

(thunderbird_esr68+ fixed, thunderbird75 fixed)

RESOLVED FIXED
Thunderbird 76.0
Tracking Status
thunderbird_esr68 + fixed
thunderbird75 --- fixed

People

(Reporter: standard8, Assigned: darktrojan)

References

Details

Attachments

(1 file, 1 obsolete file)

A week or so ago, Thunderbird Conversations 3.0.16 was released. When I looked at the stats yesterday, I noticed that only 500 or so installs had updated/installed it.

Normally the vast majority of users migrate within a day or so.

The thing I realised that is different is that 3.0.16 introduces the "addressBooks", "messagesRead", "messagesMove" permissions into the manifest (it just had storage before).

I have just been doing some testing, and there is NO prompt in Thunderbird, unless I manually go into the add-on manager and check for updates.

Requesting tracking, as with the move to WebExtensions, this is going to stop a lot of work going out to users for existing extensions to move across.

STR

  1. Set extensions.update.interval to a reasonably small value, I did 1800 to set it for every half hour.
  2. Install Thunderbird Conversations 3.0.12.
  3. Restart Thunderbird
  4. Open the error console and turn on xhrs.
  5. Wait half an hour.

Expected Results

Thunderbird should prompt or provide some indication that an update is waiting. In Firefox, there's a yellow triangle displayed on the three-bar menu, and then when you open it, you get information about the fact an add-on wants to update.

I'm not sure if Firefox also opens an actual prompt, I don't think it does.

Actual Results

No prompts. You can see the xhr to versioncheck-bg.addons.thunderbird.net go through, but nothing happens to tell the user.

I should have said, the versioncheck does list the latest version of Conversations (3.0.17) as being available.

Priority: -- → P1
Assignee: nobody → geoff
Attached patch 1620861-update-prompt-1.diff (obsolete) — Splinter Review

:-(

Attachment #9132728 - Flags: review?(mkmelin+mozilla)
Attachment #9132728 - Flags: approval-comm-esr68?
Attachment #9132728 - Flags: approval-comm-beta?
Depends on: 1621841

Here's another nasty little mistake in the same code. Found while seeing what tests I could borrow for bug 1621841.

Attachment #9132760 - Flags: review?(mkmelin+mozilla)
Attachment #9132760 - Flags: approval-comm-esr68?
Attachment #9132760 - Flags: approval-comm-beta?
Attachment #9132728 - Attachment is obsolete: true
Attachment #9132728 - Flags: review?(mkmelin+mozilla)
Attachment #9132728 - Flags: approval-comm-esr68?
Attachment #9132728 - Flags: approval-comm-beta?
Comment on attachment 9132760 [details] [diff] [review]
1620861-update-prompt-2.diff

Review of attachment 9132760 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mkmelin
Attachment #9132760 - Flags: review?(mkmelin+mozilla) → review+
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 76.0

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/6e05e1715471
Fix prompt for extension permission updates. r=mkmelin DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Comment on attachment 9132760 [details] [diff] [review]
1620861-update-prompt-2.diff

OK for beta .... and ESR assuming no problems develop
Attachment #9132760 - Flags: approval-comm-esr68?
Attachment #9132760 - Flags: approval-comm-esr68+
Attachment #9132760 - Flags: approval-comm-beta?
Attachment #9132760 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.