1621841 - Update extensions prompts code to match Firefox

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, task)

Description

[Geoff Lankow (:darktrojan)]

Our extension prompt code is a horrible mash-up of various bits of Firefox code, and it needs updating. I'm going to try to copy over a bunch of Firefox tests, too.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1621841-pt1-update-code-1.diff

This brings our code up-to-date with mozilla-central's ExtensionsUI.jsm and browser-addons.js. I've pulled apart the implementations of gXPInstallObserver and ExtensionsUI which were combined previously due to a lot of overlap. This turned out to be a mistake from a maintainability point of view.

Since in this patch I'm mostly trying to achieve parity with the Firefox code, I'll post the differences between ours and theirs which will be easier to read than this.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1621841-pt1-update-code-1.gxpinstallobserver.diff

This is the difference between Firefox's gXPInstallObserver and ours.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1621841-pt1-update-code-1.extensionsui.diff

This is the difference between Firefox's ExtensionsUI object and ours.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9133782 [details] [diff] [review]
1621841-pt1-update-code-1.diff

Review of attachment 9133782 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine to me, r=mkmelin

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1621841-pt2-all-appmenu-buttons-1.diff

Part two: this keeps all of our appmenu buttons on the same page with regards to alert badges.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1621841-pt3-tests-1.diff

Part three: tests for all of the above. This is all copied from mozilla-central (browser/base/content/test/webextensions) with some changes to make it work in Thunderbird. Two tests were dropped because they test things that Thunderbird doesn't do.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/808f7c2c6680
Update extensions prompts code to match Firefox. r=mkmelin
https://hg.mozilla.org/comm-central/rev/e3d50753c9d8
Make all appmenu toolbar buttons display alerts. r=mkmelin
https://hg.mozilla.org/comm-central/rev/a12bb1124869
Copy Firefox's extension prompt tests and adapt them to Thunderbird. r=mkmelin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c038cdf6e638
follow-up - Replace a popup notification I mistakenly removed. rs=bustage-fix DONTBUILD