1621319 - Two non-native widget test fixes.

Status: RESOLVED FIXED

(Core :: Widget, defect, P2)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1621319 - fix test_bug365410.html with non-native theme enabled. r=mstange,spohl

Our <select multiple> has enough padding so that both sides take more space that
one list item, and since this test sets the height explicitly and <select> has
box-sizing: border-box by default, page-up / page-down steps through one less
item than what the test expects.

I think this is a test bug, but let me know if you want some bug on file to
consider reducing this padding for non-native theme.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1621319 - Implement GetWidgetBorder properly for some widgets. r=spohl,mstange

I've left checkbox / radio / range-thumb alone because they don't have borders
on gtk either. We need this for the next patch to fix our test.

In particular, our combination of padding + no border means that
sanityEventUtils tries to hit an <input>, but it hits the anonymous scrollable
element instead, and asserts that it doesn't.

I don't think that test is particularly correct, but implementing
GetWidgetBorder works around it, and seems like the right thing to do anyways.

Depends on D66239

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1621319 - Make test_sanityEventUtils test synthesizeMouseExpectEvent with something else than a form control. r=smaug

Depending on the widget implementation details, hitting one pixel inside the
input may hit the input itself, or may hit the anonymous scrollable element
instead.

synthesizeMouseExpectEvent checks the originalTarget, for some reason:

https://searchfox.org/mozilla-central/rev/070a000dd49aac4a26147e137efcd91a728d13b8/testing/mochitest/tests/SimpleTest/EventUtils.js#1419

I'm not sure what the reason for that is, or why test_sanityEventUtils needs to
test it using an <input>, but I don't want to think too hard about it.

This ensures we hit the border on the <input> and thus target the right element.

Depends on D66240

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b65f1bde461a
fix test_bug365410.html with non-native theme enabled. r=mstange
https://hg.mozilla.org/integration/autoland/rev/0522121ddf22
Implement GetWidgetBorder properly for some widgets. r=mstange
https://hg.mozilla.org/integration/autoland/rev/9181798549f2
Make test_sanityEventUtils hit the border of the input, not the contents inside. r=smaug

Comment 5

[Dorel Luca [:dluca]]

Backed out 3 changesets (bug 1621319) for Mochitest failures in Harness_sanity/test_sanityEventUtils.html

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292593834&repo=autoland&lineNumber=5398

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=292593834&revision=9181798549f23ad1444142ac9d69a5aef90c9f1e

Backout:
https://hg.mozilla.org/integration/autoland/rev/814f2005218bd91bef0508131a696d81bc344424

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b57063dccba3
fix test_bug365410.html with non-native theme enabled. r=mstange
https://hg.mozilla.org/integration/autoland/rev/867b615582c9
Implement GetWidgetBorder properly for some widgets. r=mstange

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b57063dccba3
https://hg.mozilla.org/mozilla-central/rev/867b615582c9

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efb8d3e172eb
Make test_sanityEventUtils test synthesizeMouseExpectEvent with something else than a form control. r=smaug

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/efb8d3e172eb