1623471 - Hide update announcement banner

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, task)

Description

[athomas]

A banner was added to the new tab in https://bugzilla.mozilla.org/show_bug.cgi?id=1603275 announcing the upcoming upgrade with a link to the blog post. This banner should now be removed until we decide to further inform users about Fenix

---

Acceptance Criteria

• Upgrade banner on new tab is hidden from all users
• Account banner on new tab is unaffected (it will still show & behave as it did previously)
• Banner can be turned back on in future if needed

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1623471 - Temporarily disable the upcoming update banner; r?AndreiLazar

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Since this feature was only available on release versions of the app, which cannot be built on TH I've made a local build containing the above patch - fennec-68.7.0.en-US.android-arm.apk

TH builds, including release - https://treeherder.mozilla.org/#/jobs?repo=try&revision=91c76b483813f69b0da375dce6bf9780c38554aa
(Thanks Ryan!)

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Ashley, can this go out in the next Fennec update, early April?

Comment 4

[athomas]

Yes, let's include this in the early April release

Comment 5

[Diana Rus]

Hi, i tested the change with the target.apk build from Comment2 with Google Pixel 3 XL (Android 9), Samsung Galaxy S9 (Android 8) and Sony Xperia Z5 (Android 7).
Scenarios checked
First install:
Transition banner is not displayed on the "Top Sites" tab after Start browsing
Transition banner is not displayed on the "Top Sites" new tab.
Transition banner is not displayed in Private mode on a new tab.
Account banner -> User can access the about:accounts page through Sign Up button-the user is logged in - Both Normal and private browsing
Account banner -> User can access the Sign In link from the banner - Both Normal and private browsing
Account banner -> The account banner is not displayed anymore after being logged with an account
Account banner -> The banner can be dismissed/cancelled by tapping on the "x" element - The account banner is not present anymore.
Clear Data device level:
Transition banner is not displayed after making a clear data from device level in device Settings/Apps/Firefox app/Storage/Clear Data.

No Transition Banner was encountered while testing this scenarios.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9134702 [details]
Bug 1623471 - Temporarily disable the upcoming update banner; r?AndreiLazar

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Product requirement.
• User impact if declined: False expectations for users.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change, verified by QA
• String or UUID changes made by this patch:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9134702 [details]
Bug 1623471 - Temporarily disable the upcoming update banner; r?AndreiLazar

Approved for Fennec 68.7.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/3a6123da412c

Comment 9

[Diana Rus]

Hi, verified as fixed with Samsung Galaxy S9 (Android 8) and Sony Xperia Z5 (Android 7) on Firefox RC 68.7.0 the scenarios from Comment5.