1641037 - Show Update Announcement Banner

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, task, P1)

Description

[athomas]

Summary

Display update banner on the new tab page to all eligible users

Acceptance Criteria

• A banner is shown on new tab page announcing update (unhide existing banner)
• The look, content, and link in the banner remain the same as previously implemented
• The behaviour of the banner matches what was originally implemented
  • Transition banner is shown on the new tab page to all users eligible for Fenix upgrade (everyone except users on Android versions below 5.0)
  • Users can dismiss the new banner, which means it will not be shown again

Notes

This was the previous ticket to hide the banner: https://bugzilla.mozilla.org/show_bug.cgi?id=1603275

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1641037 - Show an upcoming update promo banner.

This patch re-enables the promo banner added in bug 1603275.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Try build with the above patch for testing - https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fb97da73bdef224724b770f9282ec232eece966

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

[Tracking Requested - why for this release]:

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 9152003 [details]
Bug 1641037 - Show an upcoming update promo banner.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required change to prepare for the Fennec to Fenix migration.
• User impact if declined: This banner is part of critical messageing about the upcoming changes.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch previously landed and was commented out.
• String or UUID changes made by this patch:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9152003 [details]
Bug 1641037 - Show an upcoming update promo banner.

Approved for Fennec 68.9.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/922c778024f323a5042778bc41e1315bb091044f

Comment 7

[Diana Rus]

Hi, verified as fixed with Google Pixel 3XL (Android 9), Samsung Galaxy S9 (Android 8) and Sony Xperia Z5 (Android 7) on Firefox Release 68.9.0.
Verified with scenarios from Comment and Comment