1623484 - Runtime.evaluate and Runtime.callFunctionOn return wrong data for Symbol and BigInt types

Status: RESOLVED FIXED

(Remote Protocol :: CDP, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

While implementing bug 1607560 I noticed that for both the Symbol and BigInt wrong data is returned.

Chrome:

>>> var result = Runtime.evaluate({ expression: "42n"});
>>> result
Promise {
  {
    result: { type: 'bigint', unserializableValue: '42n', description: '42n' }
  },
  inspect: [AsyncFunction]
}
>>> var result = Runtime.evaluate({ expression: "42n", returnByValue: false});
>>> result
Promise {
  {
    result: { type: 'bigint', unserializableValue: '42n', description: '42n' }
  },
  inspect: [AsyncFunction]
}

Firefox:

>>> var result = Runtime.evaluate({ expression: "42n"});
>>> result
Promise {
  {
    result: {
      objectId: 'c8843032-e079-7342-83ee-2814d2f17970',
      type: 'bigint'
    }
  },
  inspect: [AsyncFunction]
}
>>> var result = Runtime.evaluate({ expression: "42n", returnByValue: false});
>>> result
Promise {
  {
    result: {
      objectId: '2ff2b537-d5de-414e-b783-7290981217ca',
      type: 'bigint'
    }
  },
  inspect: [AsyncFunction]
}

It would be great to see that fixed, which would simplify the changes on bug 1607560.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This actually also affects Runtime.callFunctionOn.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1623484 - [remote] Runtime.evaluate and Runtime.callFunctionOn return wrong data for Symbol and BigInt types.

Depends on D67842

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f72cf155767
[remote] Runtime.evaluate and Runtime.callFunctionOn return wrong data for Symbol and BigInt types. r=remote-protocol-reviewers,maja_zf

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/9f72cf155767