1624231 - nsUrlClassifierDBService.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1622659 +++

+++ This bug was initially created as a clone of Bug #1622653 +++

Filling as a good first bug to learn workflows.

    } else {
      LOG(("CacheCompletion hash %X, Addchunk %d",
           result->completion.ToUint32(), result->addChunk));

      nsresult rv = tuV2->NewAddComplete(result->addChunk, result->completion);
      if (NS_FAILED(rv)) {
        return rv;
      }
      return tuV2->NewAddChunk(result->addChunk);
    }

do not use 'else' after 'return'

https://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#1041-1050

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Soumya Lahiri]

Attachment: Bug 1624231 - nsUrlClassifierDBService.cpp: do not use 'else' after 'return' r?Sylvestre

Comment 2

[Soumya Lahiri]

sylvestre: I made the revisions as you instructed. Please review them and let me know if it's okay.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a54a1bf16b2
nsUrlClassifierDBService.cpp: do not use 'else' after 'return' r=sylvestre

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/4a54a1bf16b2