1624509 - Implement Dark Mode support for simplified about:welcome

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to turn on dark mode support for about:welcome.

Update below tests include about:welcome once dark mode is supported:
toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors.js
toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js

Comment 1

[Punam Dahiya [:pdahiya]]

NI Aaron to help share design specs for dark mode support. Thanks

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1624509 - Dark mode support in simplified about:welcome

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e5b4839d371
Dark mode support in simplified about:welcome r=pdahiya

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_ext_themes_ntp_colors_perwindow.js

backout: https://hg.mozilla.org/integration/autoland/rev/f8d8fe0251d53e3b30766f7d3680ab293469a83f

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=1e5b4839d371f3faf9f974e9ad90aaf140f2d951&selectedJob=294967204

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294967204&repo=autoland&lineNumber=23650

[task 2020-03-27T00:16:11.262Z] 00:16:11 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - true == true -
[task 2020-03-27T00:16:11.262Z] 00:16:11 INFO - Buffered messages finished
[task 2020-03-27T00:16:11.266Z] 00:16:11 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be reset. - "rgb(237, 237, 240)" == "rgb(249, 249, 250)" - got "rgb(237, 237, 240)", expected "rgb(249, 249, 250)" (operator ==)
[task 2020-03-27T00:16:11.266Z] 00:16:11 INFO - Stack trace:
[task 2020-03-27T00:16:11.266Z] 00:16:11 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:89:21
[task 2020-03-27T00:16:11.266Z] 00:16:11 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:78:9
[task 2020-03-27T00:16:11.266Z] 00:16:11 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:140:12
[task 2020-03-27T00:16:11.266Z] 00:16:11 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1729:15
[task 2020-03-27T00:16:11.267Z] 00:16:11 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:281:21
[task 2020-03-27T00:16:11.267Z] 00:16:11 INFO - JSWindowActor queryreceiveMessage@resource://specialpowers/SpecialPowersParent.jsm:1063:12
[task 2020-03-27T00:16:11.267Z] 00:16:11 INFO - JSWindowActor queryspawn@resource://specialpowers/SpecialPowersChild.jsm:1684:17
[task 2020-03-27T00:16:11.267Z] 00:16:11 INFO - test_ntp_default_theme@chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:58:24
[task 2020-03-27T00:16:11.267Z] 00:16:11 INFO - test_per_window_ntp_theme/</<@chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:194:21
[task 2020-03-27T00:16:11.267Z] 00:16:11 INFO - withNewTab@resource://testing-common/BrowserTestUtils.jsm:150:24
[task 2020-03-27T00:16:11.267Z] 00:16:11 INFO - asynctest_per_window_ntp_theme/<@chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:188:32
[task 2020-03-27T00:16:11.267Z] 00:16:11 INFO - asynctestMessage@chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:88:19
[task 2020-03-27T00:16:11.267Z] 00:16:11 INFO - listener@resource://specialpowers/SpecialPowersChild.jsm:2081:33
[task 2020-03-27T00:16:11.268Z] 00:16:11 INFO - loadExtension/<@resource://specialpowers/SpecialPowersChild.jsm:2023:21
[task 2020-03-27T00:16:11.268Z] 00:16:11 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:238:21
[task 2020-03-27T00:16:11.268Z] 00:16:11 INFO - JSWindowActor querymessageListener@resource://specialpowers/SpecialPowersParent.jsm:941:16
[task 2020-03-27T00:16:11.268Z] 00:16:11 INFO - emit@resource://gre/modules/ExtensionCommon.jsm:327:32
[task 2020-03-27T00:16:11.268Z] 00:16:11 INFO - receiveMessage@resource://gre/modules/Extension.jsm:1936:20
[task 2020-03-27T00:16:11.268Z] 00:16:11 INFO - MessageListener.receiveMessageExtension@resource://gre/modules/Extension.jsm:1756:19
[task 2020-03-27T00:16:11.268Z] 00:16:11 INFO - generate@resource://testing-common/ExtensionTestCommon.jsm:458:12
[task 2020-03-27T00:16:11.268Z] 00:16:11 INFO - receiveMessage@resource://specialpowers/SpecialPowersParent.jsm:929:45
[task 2020-03-27T00:16:11.269Z] 00:16:11 INFO - JSWindowActor query*loadExtension@resource://specialpowers/SpecialPowersChild.jsm:2073:10
[task 2020-03-27T00:16:11.269Z] 00:16:11 INFO - ExtensionTestUtils.loadExtension@chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:113:33
[task 2020-03-27T00:16:11.269Z] 00:16:11 INFO - test_per_window_ntp_theme@chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:92:38
[task 2020-03-27T00:16:11.269Z] 00:16:11 INFO - Tester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-03-27T00:16:11.269Z] 00:16:11 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-03-27T00:16:11.269Z] 00:16:11 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-03-27T00:16:11.269Z] 00:16:11 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-03-27T00:16:11.270Z] 00:16:11 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be reset. - "rgb(12, 12, 13)" == "rgb(12, 12, 13)" -

Comment 5

[Punam Dahiya [:pdahiya]]

Failed test due to about:welcome default bkg color different from about:newtab and about:home, will re-submit patch with test fixed. Thanks

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d36693bbaf55
Dark mode support in simplified about:welcome r=pdahiya

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d36693bbaf55

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that the simplified UI version of the "about:welcome" page respects the browser's "Dark" theme colors.
Verified using the latest Firefox Nightly (76.0a1 Build ID - 20200329214909)installed on Windows 10 x64, Mac 10.15.4 and Ubuntu 18.04 x64.