1713783 - about:welcome (multistage) cannot be themed through extensions; browser_ext_themes_ntp_colors.js and browser_ext_themes_ntp_colors_perwindow.js are bogus

Status: RESOLVED FIXED

(WebExtensions :: Themes, task)

Description

[Rob Wu [:robwu]]

The multistage proton template for about:welcome (bug 1700729) cannot be themed through extensions. The tests at browser_ext_themes_ntp_colors.js and browser_ext_themes_ntp_colors_perwindow.js (introduced in bug 1624509) misleadingly suggests that they can be.

I'll clean up the test.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1713783 - Remove inaccurate theme tests for about:welcome

Comment 2

[Rob Wu [:robwu]]

According to :pdahiya, setting browser.aboutwelcome.protonDesign should revert the change from bug 1700729. I did set the pref but the about:welcome page was still purple and not themeable. While pressing F5 I noticed that the background was initially set as specified by the theme, but that the element in front of it (with the purple background) fully covers that background, so effectively the about:welcome screen is not themeable.

I ran a bisect and found that starting from bug 1649292, the about:welcome screen is not themeable any more.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a32963ab6b17
Remove inaccurate theme tests for about:welcome r=rpl,pdahiya

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a32963ab6b17