1624538 - The tabs like "Add-Ons", "Themes", etc., always report 0 items even though several are actually installed.

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Marco Zehe (:MarcoZ)]

First, I don't know if this is also happening visually. With a screen reader, like NVDA:

1. Open about:addons.
2. Tab to the list of tabs.
   • Result: Screen reader will say "Extensions, 0 extensions".
3. DownArrow through the list.
   • Result: Screen reader will announce 0 items for each of the Themes, Plugins, and Dictionaries entries.

Expected: Screen reader should speak the actual number.

Comment 1

[Alex ARNAUD]

I'm reproducing this too on GNU/Linux with Orca. There is no problem visually, this is only a problem with what it is reported to screen reader..

Comment 3

[Alex ARNAUD]

Sorry, I've closed the wrong issue.

Comment 5

[James Teh [:Jamie]]

Looking at the markup for those items, I see this:

<richlistitem is="addon-category" xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="category-extension" value="addons://list/extension" class="category" name="Extensions" tooltiptext="Extensions" priority="4000" count="0" selected="true" current="true">
  <image class="category-icon"/>
  <label class="category-name" crop="end" flex="1" value="Extensions"/>
  <label class="category-badge" value="0"/>
</richlistitem>

Screen readers report "Extensions 0 Extensions". Let's break that down:

1. "Extensions" comes from the category name (.category-name). Simple enough.
2. "0" comes from the badge (.category-badge). This is hidden, but our XUL label code is still picking it up for some reason. I imagine it is only shown when the badge is greater than 1; e.g. for updates, it probably indicates the number of updates?
3. The final "Extensions" is in the acc description, not the acc name. That's coming from tooltiptext on the richlistitem. Normally, we'd de-duplicate that because the acc name would be "Extensions" as well, but it's not because of (2).

Comment 6

[Mark Striemer [:mstriemer]]

This will be changing in bug 1525178 as the sidebar moves to HTML. I'll need to verify that that one works correctly. I suspect that no counts will be announced, but the Available Updates one should be announcing it.

Comment 7

[James Teh [:Jamie]]

The bogus counts are gone. Yay! However, I don't have any badges, so I can't verify that the count does show up when there is a badge.

Comment 8

[Mark Striemer [:mstriemer]]

I just tested this with NVDA and I sometimes hear the badge count called out. It's shown with content: attr(badge-count) in an ::after.

When I focus the tablist and use up/down to navigate it I don't hear the count called out, but if I use alt+up/alt+down I do. Without NVDA enabled up/down will also activate the button to switch the view, but with NVDA that only happens with alt+up/alt+down.

The only case where the badge is shown now should be on the "Available Updates" button when there are updates ready to be installed.

STR to have available updates shown

1. Install an old add-on version from AMO
   • https://addons.mozilla.org/en-US/firefox/addon/b-itch-to-boss/versions/
   • Or "See all versions" from a details page
2. Go to the add-on's details page
3. Disable automatic updates
4. Check for updates for the add-on on the details page, or all add-ons from the "Tools for all add-ons" button

The "Available Updates" button should now be shown

Comment 9

[Mark Striemer [:mstriemer]]

I set the role="tab" (bug 1626378) and tested again and it seems to work as expected now. Here's the speech viewer log from NVDA:

tab control
Extensions  tab  selected  2 of 5
Themes  tab  selected  3 of 5
Plugins  tab  selected  4 of 5
Available Updates 1  tab  selected  5 of 5

Does this seem appropriate? Should there be any other text included or is just the number enough?

Comment 10

[James Teh [:Jamie]]

(In reply to Mark Striemer [:mstriemer] from comment #9)

Does this seem appropriate? Should there be any other text included or is just the number enough?

I think this is sufficient. Some would argue we should have more descriptive text like "1 update available" or something, but I'm not convinced it's necessary. Given we're talking about updates, there's sufficient context IMO. Marco, thoughts?

Comment 11

[Marco Zehe (:MarcoZ)]

I agree. I also find it superfluous to hear "Updates, 1 update available tab, 5 of 5". The way this is presented now sounds sufficient to me.

Comment 12

[Mark Striemer [:mstriemer]]

Fixed by bug 1525178 and bug 1626378.

Thanks for confirming!