1624713 - Convert editBookmarkOverlay.dtd to fluent

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, task, P1)

Description

[:Gijs (he/him)]

There are some 20-ish strings here:

browser/locales/en-US/chrome/browser/places/editBookmarkOverlay.dtd

They are used exclusively from https://searchfox.org/mozilla-central/source/browser/components/places/content/editBookmarkPanel.inc.xhtml

The new ftl should live in https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/ .

The included .xhtml content gets used in 3 places, see https://searchfox.org/mozilla-central/search?q=editbookmarkpanel.inc.&case=false&regexp=false&path=

In all except browser-doctype.inc, these can just be added as regular .ftl links in the files that are including the .inc.xhtml file.

In the browser-doctype case, it should be possible to remove the DTD reference, and then use MozXULElement.insertFTLIfNeeded() to insert the .ftl from https://searchfox.org/mozilla-central/rev/c80fa7258c935223fe319c5345b58eae85d4c6ae/browser/base/content/browser-places.js#306 , without adding it as a fixed .ftl link in browser.xhtml. We should check if this works correctly and doesn't leave warnings in the browser console. I think it will, but if not, I guess we should add the new .ftl in browser.xhtml after all.

To test this, simply load any page and click the star button in the address bar (or hit the shortcut - cmd-D on mac, ctrl-D on Windows).

Comment 1

[Artem]

Attachment: Bug 1624713 - Convert editBookmarkOverlay.dtd to fluent r?mconley,gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49509cff8c94
Convert editBookmarkOverlay.dtd to fluent r=Gijs,fluent-reviewers,flod

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 49509cff8c94 (Bug 1624713) for causing bc failures in nsAtom.h CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=294916567&resultStatus=testfailed%2Cbusted%2Cexception&revision=49509cff8c94d3758e0713c26d3ed43a7762570b

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294916567&repo=autoland&lineNumber=2563
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294911091&repo=autoland&lineNumber=35254
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294924717&repo=autoland&lineNumber=2758

Backout: https://hg.mozilla.org/integration/autoland/rev/a74b5711286bdab2f7d72eb7d9e25775cae368f5

Comment 4

[:Gijs (he/him)]

I filed a bug to unblock this landing; I don't think it's anything to do with the contents of the patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2aecef76edd
Convert editBookmarkOverlay.dtd to fluent r=Gijs,fluent-reviewers,flod

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/a2aecef76edd

Comment 8

[Anca Soncutean, Desktop QA]

Verified fixed as part of PI 551; tested with Nightly 77 across platforms (Windows 10, macOS 10.15 and Ubuntu 18.04).