Closed
Bug 1625021
Opened 5 years ago
Closed 5 years ago
Remove HideScriptFromDebugger from MutableScriptFlags.
Categories
(Core :: JavaScript Engine, task, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla76
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: caroline, Assigned: caroline)
References
Details
Attachments
(2 files)
The mutable flag HideScriptFromDebugger is only used inside of DebugAPI::onNewScript (sans some asserts). The only case in which HideScriptFromDebugger is set is when tellDebuggerAboutCompiledScript is called from CreateGlobalScript we can do a check of the compilationInfo.option.hideScriptFromDebugger in tellDebuggerAboutCompiledScript. This allows us to remove the script flag all together.
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → ccullen
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D68306
Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/611350ae8292
Remove use of HideScriptFromDebugger mutable flag. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/92ccbb744377
Completely remove HideScriptFromDebugger flag. r=mgaudet
|
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/611350ae8292
https://hg.mozilla.org/mozilla-central/rev/92ccbb744377
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•