1625466 - Fix print statements in appini_header.py

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ian Neal]

Builds specifying "ac_add_options --disable-updater" in .mozconfig fail with the following:

3:28.20 File "c:/Users/xxxxxxxx/mozilla/build/appini_header.py", line 35, in main
3:28.20 print >>sys.stderr,
3:28.20 TypeError: unsupported operand type(s) for >>:'builtin_function_or_method' and '_io.TextIOWrapper'. Did you mean "print(<message>, file=<output_stream>)"?

after fixing the prints in appini_header.py, you get the real error:

0:02.29 Missing values in application.ini: AppUpdate:url
0:02.30 gmake[4]: *** [backend.mk:23: .deps/application.ini.h.stub] Error 1
02.30 gmake[3]: *** [c:/Users/xxxxxxxx/mozilla/config/recurse.mk:101:
build/export] Error 2

Comment 1

[Ian Neal]

Attachment: Bug 1625466 - Fix print statements in appini_header.py r=rstewart

Comment 2

[Ian Neal]

As regards the real error, in build/application.ini.in AppUpdate:url is specifically NOT defined if MOZ_UPDATER is false. This test for existence of AppUpdater:url should also be only performed if MOZ_UPDATER is defined.

Comment 3

[mac198442]

See also bug 1526451

Comment 4

[mac198442]

Thanks Ian I typo'd the bug number.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8047c4c6b0f
Fix print statements in appini_header.py r=rstewart

Comment 6

[Bob Clary [:bc] (inactive)]

(In reply to Ian Neal from comment #0)

after fixing the prints in appini_header.py, you get the real error:

Ian: Is there a bug for this?

Comment 7

[Ian Neal]

(In reply to Bob Clary [:bc:] from comment #6)

(In reply to Ian Neal from comment #0)

after fixing the prints in appini_header.py, you get the real error:

Ian: Is there a bug for this?

Yes, Bug 1625461

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a8047c4c6b0f