Closed Bug 1625682 Opened 5 years ago Closed 5 years ago

moz-extension: redirect by webRequest is loaded in the wrong process in xpcshell test

Categories

(WebExtensions :: Request Handling, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1580811

People

(Reporter: willdurand, Unassigned)

Details

Writing a xpcshell test case for https://bugzilla.mozilla.org/show_bug.cgi?id=1573456 revealed an issue: the process does not seem correct as there is no webRequest API for instance. That being said, a similar "browser" test works so this is likely a problem with the xpcshell env.

Yeah, currently (before Fission) process selection happens in browser code, and is totally missing from xpcshell tests (unless we implement it in our test suite).

So, I believe bug 1573456 should be tested using a browser mochitest, and I'm going to dupe this to bug 1580811, which is not strictly the same bug, but is related enough to not need a separate tracking bug.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE

@:zombie Does comment 1 imply that this feature (redirecting moz-extension:-pages to the correct process for TOP-LEVEL browsing contexts) is broken on Android / GeckoView ?

I want the xpcshell to pass so that we have some assurance that this works on GeckoView, but from your description it seems that a xpcshell test would not be a realistic proxy for actual browsers. If you know off the top of your head, I would appreciate some links to the source code that are responsible for assigning the processes in the browser. I believe that I saw the relevant code when I debugged other issues a few weeks ago, but I'm still interested in what you specifically had in mind with your comment.

You need to log in before you can comment on or make changes to this bug.