1625721 - Split arrow panel styles and load them as a shadow DOM stylesheet

Status: NEW

(Toolkit :: Themes, task, P3)

Description

[Tim Nguyen :ntim]

We should split out styles from xul.css and popup.css into a new file.

The biggest benefit is that we can get rid of these duplicated styles:

https://searchfox.org/mozilla-central/rev/3a9dbc403f33cca1ff43326d78340add7d996350/browser/base/content/browser.css#1030-1103

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1625721 - Split out arrow panel styles and load them as shadow DOM stylesheet.

Comment 2

[Tim Nguyen :ntim]

This works very nicely and is a really good clean up, but it breaks the transform animation on the temporary cui-widget-panels. I'm guessing this is because the CSS for the animation is now only loaded in the shadow root, and since the temporary panels are dynamically appended, the CSS doesn't have time to load in time for the transition.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c312e49ee09
Split out arrow panel styles and load them as shadow DOM stylesheet. r=dao

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 6c312e49ee09 (Bug 1625721) for build bustages at popup.css.
https://hg.mozilla.org/integration/autoland/rev/171100452c07db7f9c8f5fa8d907af43a3abe685

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=6c312e49ee094e66684abedc5ee314dfa595bfa1&selectedJob=298590113

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298590113&repo=autoland&lineNumber=67220

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a0b7de7386c
Split out arrow panel styles and load them as shadow DOM stylesheet. r=dao

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8a0b7de7386c

Comment 7

[Matthew N. [:MattN]]

The backout of bug 1625720 and bug 1625721 also fixed the border of arrow panels which didn't have the proper fill under the border, especially under the border-radius:
https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=5daf558349272b05cee2c9097a9499ff4d7363e6&newProject=mozilla-central&newRev=71cb60d53ecd0c357f004df14c673184f85b91f7

Comment 8

[Mathew Hodson]

To clarify what happened, this bug was reopened because changeset 8a0b7de7386c was backed out in bug 1634865 for causing regressions such as bug 1633356.