1626185 - Remove checked="false" attribute from <checkbox> since unchecked is the default, and checked="false" will actually mean checked

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Khushil Mistry [:khushil324]]

"Remove conversation data" checkbox is ticked.
Showing an error: JavaScript error: chrome://messenger/content/SpotlightIntegration.js, line 48: TypeError: can't access property "path", aFolder.filePath is null

Comment 1

[Patrick Cloke [:clokep]]

This doesn't block Matrix, but is a regression.

Comment 2

[Khushil Mistry [:khushil324]]

checked="false" is behaving as the checked box. So if you want to uncheck the checkbox, just remove the checked attribute. Checked is not taking any value, <checkbox checked/> will behave as the checked box. <checkbox/> will behave as the unchecked box.
If you toggle the checkbox, you will see <checkbox checked="true"/> and <checkbox/>.

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1626185_remove-checked-false-attribute-checkbox-0.patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9137391 [details] [diff] [review]
Bug-1626185_remove-checked-false-attribute-checkbox-0.patch

Review of attachment 9137391 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cbc727e838c5
Remove checked=false attribute from checkbox for the default unchecked. r=mkmelin