1626198 - Fix flushing in XULTreeElement::GetTreeBodyFrame.

Status: RESOLVED FIXED

(Core :: XUL, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1626198 - Fix flushing in XULTreeElement::GetTreeBodyFrame. r=smaug

The code was knowingly broken (because of bug 585123). But that bug is closed,
and the broken code is causing asserts to fire in bug 1624488 because well, it's
broken ;)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e104285508a
Fix flushing in XULTreeElement::GetTreeBodyFrame. r=smaug

Comment 3

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 6e104285508a (Bug 1626198) for causing perma bc mochitest failures in browser/components/places/tests/browser/browser_sidebarpanels_click.js CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=295574076

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295574076&repo=autoland&lineNumber=4010

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5848a5802e89
Backed out changeset 6e104285508a for causing perma bc mochitest failures in browser/components/places/tests/browser/browser_sidebarpanels_click.js CLOSED TREE

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1626198 - Test RTL bookmarks panels better. r=ntim

I can reproduce the same test failure if I add a flush after setting the
direction value in changeSidebarDirection.

This is arguably a XUL tree bug in a way, but it's a tough one to fix. But the
test is testing something else, and is testing it poorly. Make it test RTL
sidebars properly.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43b2b0b72cf8
Fix flushing in XULTreeElement::GetTreeBodyFrame. r=smaug
https://hg.mozilla.org/integration/autoland/rev/db538dca6ea1
Test RTL bookmarks panels better. r=ntim

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/43b2b0b72cf8
https://hg.mozilla.org/mozilla-central/rev/db538dca6ea1