16263 - [DOGFOOD] Can't view inline images for imap

Status: VERIFIED FIXED

(MailNews Core :: Networking, defect, P3)

Description

[Scott MacGregor]

Have you ever noticed that we can't view inline messages for imap? In addition,
the attachment buttons for message display don't work for imap either.

Basically anything that the mime converter referred to using a part didn't work.
If you had an image in a message and tried to display it, mime would generate a
url for that image that looked like the following (excuse the unescaped string):

imap://dredd.mcom.com:143/fetch%3EUID%3E/Inbox%3E37512?part=1.2

So mime tacks on the ?part=1.2 to refer to the embeded image.

When layout tries to display the message, it takes this url and hands it to
necko asking for necko to create a url. Since it's an imap url, necko takes the
string and gives it to the imap protocol handler, calling nsImapService::NewURI.
Previously, this function was unimplemented. So we wouldn't create a url and
returned an error code. Thus the embedded image never displayed.

I sat down tonight and implemented nsImapService::NewUri to take a hard coded
url string (like the one I listed above) and create a nsIImapUrl (with all the
necessary bells and whistles) to give back to the parser which then runs the
url.

Things seem to be working much better now. inline images in imap messages are
now working and showing up. Also I've the attachement button also started
working properly after these changes.

Comment 1

[Scott MacGregor]

I have changes for this ready to go. I may just have Seth review this stuff so I
can check it in tonight instead of waiting for imap gurus tomorrow.

Comment 2

[Scott MacGregor]

Seth reviewed the changes for me. Marking as fixed.

Enjoy!

Comment 3

[lchiang]

There are some other bugs filed on the attachment button not working.  Peter -
can you find those and see if they are now fixed?

Comment 4

[pmock]

Sure Lisa.  I currently trying to verify this bug.  So on today Mac mozilla
build
(ftp://sweetlou/products/client/seamonkey/macos/8.x/ppc/1999-10-13-08-M11/mozilla-mac-M11.sea.bin),
attachment view inline ok but there may be an issue with the size of the
attachment.  Small attachment less than 30K appears to display fine but larger
attachment don't display at all.  Trying to narrow it downnow...

The bug 16145 - save attachment button is missing on the Mac is still open.

Comment 5

[jefft]

*** Bug 12255 has been marked as a duplicate of this bug. ***

Comment 6

[pmock]

Verified as resolved under the following builds and platforms:
 Win32 commercial seamonkey build 1999-10-13-09 installed on P166 Win98
 Linux commercial seamonkey build 1999-10-13-08 installed on P200 RedHat 6.0
 MacOS commercial seamonkey build 1999-10-13-08 installed on G3/400 OS 8.5.1

ftp://sweetlou/products/client/seamonkey/windows/32bit/x86/1999-10-13-09-M11/
ftp://sweetlou/products/client/seamonkey/unix/linux_glibc/2.2/x86/1999-10-13-08-M11/
ftp://sweetlou/products/client/seamonkey/macos/8.x/ppc/1999-10-13-08-M11/

Note: found new file attachment bug under IMAP -> bug 16334
      BTW. found new file attachment bug under POP3 -> bug 16338