1626765 - nsWindow.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1626762 +++

+++ This bug was initially created as a clone of Bug #1626761 +++

Filling as a good first bug to learn workflows.

 if (parentWidget) {
          return DesktopToLayoutDeviceScale(
              parentWidget->RoundsWidgetCoordinatesTo());
        } else {
          NS_WARNING("Widget has no parent");
        }

do not use 'else' after 'return'

https://searchfox.org/mozilla-central/source/widget/gtk/nsWindow.cpp#806

As the change is pretty easy, it is mostly to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[NicolasPacheco]

Attachment: Bug 1626765 - delete 'else' after 'return'. r?rstewart

Depends on D70144

Comment 2

[NicolasPacheco]

Attachment: Bug 1626765 - delete 'else' after 'return'. r?rstewart

Depends on D70145

Comment 3

[NicolasPacheco]

Attachment: Bug 1626765 - delete 'else' after 'return'. r?rstewart

Depends on D70145

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Nicolas, please read https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html#to-update-a-submitted-patch :)

Comment 5

[NicolasPacheco]

Sorry! I had some issues with hg commit --amend, because I made many changes. I should use hg histedit instead. I think I did it correctly now.
Thanks for you help.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbdf5e1478a9
delete 'else' after 'return'. r=sylvestre

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bbdf5e1478a9