Closed Bug 1626875 Opened 4 months ago Closed 4 months ago

TestTabList used for xpcshell tests should return TabDescriptors

Categories

(DevTools :: about:debugging, task, P1)

task

Tracking

(Fission Milestone:M6, firefox76 fixed)

RESOLVED FIXED
Firefox 76
Fission Milestone M6
Tracking Status
firefox76 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

(Whiteboard: dt-fission-m2-mvp)

Attachments

(1 file)

The TestTabList defined at https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/devtools/server/tests/xpcshell/testactors.js#56 is a mock implementation of webbrowser is Mock implementation of the webbrowser TabList.

In Bug 1579042, the regular webbrowser TabList started returning an array of TabDescriptorActors instead of an array of BrowsingContextTargetActors. However we didn't migrate the xpcshell TestTabList at the same time.

For now xpcshell tests are still working thanks to the backward compatibility code which is supposed to handle older servers. But we should migrate it so that it doesn't prevent us from removing the backward compat code.

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf163aa1c343
Return TabDescriptors in TestTabList for DevTools xpcshell tests r=ochameau

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Fission Milestone: --- → M6
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
You need to log in before you can comment on or make changes to this bug.