1626945 - Running ./mach reftest on android emulator fails to find fix_stacks

Status: RESOLVED FIXED

(Testing :: General, defect, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Full output from `./mach reftest ...`

I did a ./mach bootstrap for android (non-artifact) builds and then built for android. Then attempted to run a reftest via ./mach reftest. It failed with a python error when trying to find the fix_stacks module. See attached log.

This might be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1623134

Comment 1

[Bob Clary [:bc] (inactive)]

You can work around the issue by using export MOZ_DISABLE_STACK_FIX=1

Comment 2

[Kartikaya Gupta (email:[e-mail])]

That works, thanks!

Comment 3

[Nicholas Nethercote [inactive]]

This might be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1623134

That bug is unrelated. This is similar to bug 1624980, i.e. there's a mach bootstrap path that should install fix-stacks but doesn't. I'll take a look today, hopefully this bug will be as easy as that one.

Comment 4

[Geoff Brown [:gbrown]]

Great, thanks!

In the interest of not breaking this another way, I'll mention that I also notice https://phabricator.services.mozilla.com/D68617 appears to remove the fix-stacks toolchain fetch from android. Can you have a look at that and comment if needed?

Comment 5

[Nicholas Nethercote [inactive]]

This is similar to bug 1624980, i.e. there's a mach bootstrap path that should install fix-stacks but doesn't.

I was wrong about that. The fix-stacks executable is installed just fine by mach bootstrap. The problem here is that the fix_stacks.py script (which is a Python wrapper for fix-stacks) is not being found.

This might be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1623134

Yes, it sounds just the same as bug 1622701 comment 3. If so, the fix will simply be to wait for bug 1623134 to land.

Comment 6

[Nicholas Nethercote [inactive]]

Bug 1623134 has been resolved. kats, can you update and try again to see if it fixes your problem?

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Yup, this works now. Thanks!