1627200 - <datalist> in popup.html throws error in one of the autocomplete??.js

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[klaus]

User Agent: Mozilla/5.0 (Windows NT 10.0; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

a mini popup of height 0.5mm is displayed. Debugger indicates error in one of the autocomplete.js files. Example at: https://github.com/opto/TB_MailExt_1 brach select_datalist.

I saw there is a large number of bugs relating to datalist but they are all resolved.

Comment 1

[Geoff Lankow (:darktrojan)]

This doesn't appear to work anywhere in Thunderbird.

Comment 2

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1627200-datalist-1.diff

Aleca, you're most likely to notice if I've broken anything here. The first part of this patch fixes the popup itself. The second part restricts the existing custom CSS to local-abook and remote-abook types – ie. autocomplete results from the address book, I think they're the only things this CSS is for.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9156131 [details] [diff] [review]
1627200-datalist-1.diff

Review of attachment 9156131 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good and it doesn't seem to affect any other autocomplete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/292ed2f81859
Fix autocomplete popup of <input> with <datalist>. r=aleca

Comment 6

[Geoff Lankow (:darktrojan)]

I forgot that gloda-autocomplete-input.js throws exceptions like mad when using datalist.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1627200-gloda-exceptions-1.diff

Comment 8

[Alessandro Castellani [:aleca]]

Comment on attachment 9156160 [details] [diff] [review]
1627200-gloda-exceptions-1.diff

Review of attachment 9156160 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, sorry for missing this issue.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f82b61ed451a
Mitigate exceptions thrown in gloda-autocomplete-input when using datalist. r=aleca DONTBUILD

Comment 10

[Magnus Melin [:mkmelin]]

I guess this needs uplift?

Comment 11

[Geoff Lankow (:darktrojan)]

Yes but I'm still working in this area, it can wait for the rest of the work. It may even get a test if I get that far!

Comment 12

[Geoff Lankow (:darktrojan)]

Comment on attachment 9156131 [details] [diff] [review]
1627200-datalist-1.diff

Needs to go with bug 1645945, not risky.

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9156131 [details] [diff] [review]
1627200-datalist-1.diff

Approved for beta

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9156160 [details] [diff] [review]
1627200-gloda-exceptions-1.diff

Approved for beta

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 78.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/a2681c24ae66
https://hg.mozilla.org/releases/comm-beta/rev/4e53e497dc00