Closed Bug 1627748 Opened 6 months ago Closed 5 months ago

Message pane: when prefers-color-scheme: dark is set use the approriate colours

Categories

(Thunderbird :: Theme, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 77.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

(Regressed 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

With Message prefers-color-scheme: dark set, the composer has already a dark editor background. The message pane still shows the the white background. For more consistency we should use also a dark background when we show a message which hasn't set the background colour.

This implements the same logic as bug 1622695. I moved code from composerOverlay.css to messageQuotes.css to apply on both, the composer and the message pane. And I made messageQuotes.css shared, all styles are now the same for all platforms.

When we use the dark background on message pane and mail.citation_color is on default, then citations are almost invisible because the default is #000. What do you think, should I change the default to #007cff? This is the value we use now in dark composer. With this the text is good readable on dark and light background. Or would you propose a other colour?

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9138599 - Flags: ui-review?(alessandro)
Attachment #9138599 - Flags: review?(mkmelin+mozilla)

Can you try this patch on many messages to check if we regress somehow? I already know that event invitations have white text on white background. When we land this patch I'll file a bug for Calendar.

Comment on attachment 9138599 [details] [diff] [review]
1627748-dark-messagePane-colors.patch

Review of attachment 9138599 [details] [diff] [review]:
-----------------------------------------------------------------

For standard messages this looks very good.
Unfortunately quoted text in standard messages don't look readable as it seems like we force a color black on those.
I'm attaching a screenshot.
Attachment #9138599 - Flags: ui-review?(alessandro)

The message body reads normally and it's properly styled, but the quoted text is not readable as it comes with inline style.

Yes, this is what I wrote about mail.citation_color. The user can set it manually in Prefs > General > Plain Text Messages, the colour button.

Okay, now with the pref set to #007cff. When the user has set a different colour we don't overwrite it.

Attachment #9138599 - Attachment is obsolete: true
Attachment #9138599 - Flags: review?(mkmelin+mozilla)
Attachment #9138637 - Flags: ui-review?(alessandro)
Attachment #9138637 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9138637 [details] [diff] [review]
1627748-dark-messagePane-colors.patch

Review of attachment 9138637 [details] [diff] [review]:
-----------------------------------------------------------------

The UI looks good to me, thanks
Attachment #9138637 - Flags: ui-review?(alessandro) → ui-review+
Attachment #9138637 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → Thunderbird 77.0

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8156ee771038
Message pane: when prefers-color-scheme: dark is set use the approriate colours. r=mkmelin ui-r=aleca

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Regressions: 1630551
Regressions: 1641422
You need to log in before you can comment on or make changes to this bug.