1627961 - DevTools panel tooltips appear with no background when widget.disable-native-theme-for-content is true

Status: RESOLVED DUPLICATE of bug 1691428

(Core :: Widget, defect)

Description

[Tim Nguyen :ntim]

Attachment: Screenshot

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:Honza, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can't reproduce this problem on Win10
Tim, what OS you you using?

Honza

Comment 3

[Tim Nguyen :ntim]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #2)

I can't reproduce this problem on Win10
Tim, what OS you you using?

This is macOS.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:Honza, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Nicolas, can you reproduce this on Mac?

Honza

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

no I can't.
Tim do you have specific pref turned on? (like things for WebRender ?)

Comment 7

[Tim Nguyen :ntim]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #6)

no I can't.
Tim do you have specific pref turned on? (like things for WebRender ?)

Nothing that stands out to me in about:support.

Comment 8

[Tim Nguyen :ntim]

Note that it only happens in the tooltips of the menu items.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:Honza, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Tim, is this reproducible in a new fresh Firefox profile?

Honza

Comment 11

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can't reproduce this.

Tim, please feel free to reopen if you still see it.

Honza

Comment 12

[Tim Nguyen :ntim]

I'll look again when I'll have time to update Nightly.

Comment 13

[Tim Nguyen :ntim]

This is still reproducible, but I found out this is due to widget.disable-native-theme-for-content being set to true.

Comment 14

[Markus Stange [:mstange]]

This tooltip is a XUL tooltip element in a non-chrome document. It is inside the devtools-toolbox document, at window > #toolbox-container > #aHTMLTooltip. The tooltip has -moz-default-appearance: tooltip and no background-color. The toolbox document uses the basic theme, and the basic theme does not support StyleAppearance::Tooltip, so we don't render a background.

As a solution, I think it would make sense to use the regular native theme (not the basic theme) for the toolbox document. If it uses XUL elements such as tooltips and panels, it is really built to be used in combination with the regular native theme.
I don't know what's a good way to differentiate the devtools toolbox document from, say, about:support (which probably should use the basic theme).

Comment 15

[Chris Peterson [:cpeterson]]

Tracking non-native theming bugs for Fission Beta milestone (M7).

Comment 16

[Neha Kochar [:neha]]

Only Linux NNT is a Fission blocker and this is not marked as a linux-nnt blocker so removing the Fission milestone here. If this turns out to be required for Linux-NNT, please add Fission Milestone ? to add it back to Fission triage. Thanks!

Comment 17

[Chris Peterson [:cpeterson]]

Tim, can you still reproduce this bug?

I tested Fx87 Nightly on macOS and Windows 10 with widget.disable-native-theme-for-content and I can't reproduce. Maybe this is related to some dark mode theme or setting you have enabled? I have OS dark mode enabled on both macOS and Windows 10, but my devtools UI isn't black like yours.

If this bug only affects macOS, then it doesn't need to block Fission MVP.

Comment 18

[Tim Nguyen :ntim]

I can still reproduce with the web console tooltips (notably the ones from the original screenshot), or any tooltips from the settings arrow-style panels in devtools really.

Comment 19

[Chris Peterson [:cpeterson]]

Not a Fission bug

Comment 20

[Markus Stange [:mstange]]

Something similar happens with the context menu in the sidebar of the Storage panel. Hovering over context menu items does not show a blue background.

Comment 22

[Chris Peterson [:cpeterson]]

This bug was closed as a duplicate of bug 1691428, which fixed a bug on Linux but I can still reproduce this bug's devtools tooltips bug on macOS. Should the fix for bug 1691428 also have fixed macOS? Or will "devtools should use native theme" bug 1692306 fix this bug?

Comment 23

[Emilio Cobos Álvarez (:emilio)]

This was actually fixed in bug 1696988