Closed Bug 1628094 Opened 1 year ago Closed 1 year ago

Address-bar-navigated reason not getting logged in telemetry on opening about:welcome manually via url

Categories

(Firefox :: Messaging System, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 77
Iteration:
77.1 - Apr 6 - Apr 19
Tracking Status
firefox76 + verified
firefox77 --- verified

People

(Reporter: pdahiya, Assigned: pdahiya)

References

Details

Attachments

(1 file)

Address-bar-navigated reason not getting logged in telemetry on opening about:welcome manually via url

STR:

  1. Open about:welcome by entering 'about:welcome' in URL
  2. Click Start Browsing button
  3. Enter URL

Actual Result
In browser console , telemetry logged shows up as - "event":"SESSION_END","event_context":"{"reason":"unknown"

Expected Result
"event":"SESSION_END","event_context":"{"reason":"address-bar-navigated"

Note:

  1. This issue is not replicable for new profiles when about:welcome is shown in first run flow after installing Firefox

[Tracking Requested - why for this release]:

Assignee: nobody → pdahiya
Priority: -- → P1
Iteration: --- → 77.1 - Apr 6 - Apr 19

[Tracking Requested - why for this release]: the telemetry for about:welcome is not working correctly when "about:welcome" is entered in URL bar. This will cause inaccurate data for growth experiments and first-run dashboards.

Attachment #9139548 - Attachment description: Bug 1628094 - OnLocationChange triggers inside JSWindowActorParent → Bug 1628094 - Address-bar-navigated reason not logged in telemetry on opening about:welcome manually via url
Pushed by pdahiya@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66ac5cf4ad74
Address-bar-navigated reason not logged in telemetry on opening about:welcome manually via url r=mconley
Regressions: 1630171
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77

Comment on attachment 9139548 [details]
Bug 1628094 - Address-bar-navigated reason not logged in telemetry on opening about:welcome manually via url

Beta/Release Uplift Approval Request

  • User impact if declined: the telemetry for about:welcome is not working correctly when "about:welcome" is entered in URL bar. This will cause inaccurate data for growth experiments and first-run dashboards.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1628094#c0
  • List of other uplifts needed: Bug 1630171
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Patch doesn't have any UI facing changes and fixes broken telemetry.
  • String changes made/needed: None
Attachment #9139548 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9139548 [details]
Bug 1628094 - Address-bar-navigated reason not logged in telemetry on opening about:welcome manually via url

Fixes problems with about:welcome telemetry. Approved for 76.0b6.

Attachment #9139548 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have verified that this is no longer reproducible on Firefox Nightly 77.0a1 (Build ID 20200420214939) and Firefox Beta 76.0b6 (Build ID 20200420031429) using Windows 10 x64, Linux Ubuntu 18.04 and Mac OS 10.15.
A telemetry ping is sent when navigating from about:welcome to a URL. The ping contains: "event":"SESSION_END","event_context":"{"reason":"address-bar-navigated".

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.