1628094 - Address-bar-navigated reason not getting logged in telemetry on opening about:welcome manually via url

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

Address-bar-navigated reason not getting logged in telemetry on opening about:welcome manually via url

STR:

1. Open about:welcome by entering 'about:welcome' in URL
2. Click Start Browsing button
3. Enter URL

Actual Result
In browser console , telemetry logged shows up as - "event":"SESSION_END","event_context":"{"reason":"unknown"

Expected Result
"event":"SESSION_END","event_context":"{"reason":"address-bar-navigated"

Note:

1. This issue is not replicable for new profiles when about:welcome is shown in first run flow after installing Firefox

Comment 1

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1628094 - Address-bar-navigated reason not logged in telemetry on opening about:welcome manually via url

Comment 3

[Tim Spurway [:tspurway]]

[Tracking Requested - why for this release]: the telemetry for about:welcome is not working correctly when "about:welcome" is entered in URL bar. This will cause inaccurate data for growth experiments and first-run dashboards.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66ac5cf4ad74
Address-bar-navigated reason not logged in telemetry on opening about:welcome manually via url r=mconley

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/66ac5cf4ad74

Comment 6

[Punam Dahiya [:pdahiya]]

Comment on attachment 9139548 [details]
Bug 1628094 - Address-bar-navigated reason not logged in telemetry on opening about:welcome manually via url

Beta/Release Uplift Approval Request

• User impact if declined: the telemetry for about:welcome is not working correctly when "about:welcome" is entered in URL bar. This will cause inaccurate data for growth experiments and first-run dashboards.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1628094#c0
• List of other uplifts needed: Bug 1630171
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch doesn't have any UI facing changes and fixes broken telemetry.
• String changes made/needed: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9139548 [details]
Bug 1628094 - Address-bar-navigated reason not logged in telemetry on opening about:welcome manually via url

Fixes problems with about:welcome telemetry. Approved for 76.0b6.

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2c525a668309

Comment 9

[Valentina Virlics [:vvalentina], Ecosystem QA]

I have verified that this is no longer reproducible on Firefox Nightly 77.0a1 (Build ID 20200420214939) and Firefox Beta 76.0b6 (Build ID 20200420031429) using Windows 10 x64, Linux Ubuntu 18.04 and Mac OS 10.15.
A telemetry ping is sent when navigating from about:welcome to a URL. The ping contains: "event":"SESSION_END","event_context":"{"reason":"address-bar-navigated".