1628715 - Improve use of nodiscard and nonnull_return attributes in nsTArray

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 1: Add MOZ_NONNULL_RETURN attributes to some nsTArray functions. r=#xpcom-reviewers

Depends on D70381

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 2: Disable copy assignment to FallibleTArray from infallible nsTArray. r=#xpcom-reviewers

Also prepare disabling copy construction and assignment in Bug 1628692.

Depends on D70382

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 3: Make fallible nsTArray::Assign nodiscard. r=#xpcom-reviewers

Depends on D70383

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 4: Add MOZ_NONNULL_RETURN to infallible nsTArray::ReplaceElementsAt. r=#xpcom-reviewers

Depends on D70384

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 6: Remove unused and redundant AppendElements overload. r=#xpcom-reviewers

Depends on D70385

Comment 6

[Simon Giesecke [:sg] [he/him]]

One goal in particular is that all functions that return elem_type* have either the nodiscard or the nonnull_return attribute.

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 5: Add MOZ_NONNULL_RETURN to infallible nsTArray::InsertElementsAt. r=#xpcom-reviewers

Depends on D70385

Comment 8

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 7: Add MOZ_NONNULL_RETURN to infallible nsTArray::AppendElements. r=#xpcom-reviewers

Depends on D70386

Comment 9

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 8: Add MOZ_NONNULL_RETURN to ReconstructElementAt. r=#xpcom-reviewers

Depends on D70831

Comment 10

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 9: Add MOZ_NONNULL_RETURN to InsertElementSorted. r=#xpcom-reviewers

Depends on D70832

Comment 11

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 10: Activate nodiscard attributes on AppendElement(s). r=#xpcom-reviewers

Depends on D70833

Comment 12

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 11: Add nodiscard attribute to functions unrelated to memory allocation. r=#xpcom-reviewers

Depends on D70834

Comment 13

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 1bis: Add nodiscard attribute to SwapElements. r=#xpcom-reviewers

Depends on D70835

Comment 14

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 7bis: Add gtests for nsTArray::AppendElements. r=#xpcom-reviewers

Depends on D70386

Comment 15

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 12: Add WrapNotNullUnchecked for NotNull<T*>. r=#xpcom-reviewers

Depends on D70835

Comment 16

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 13: Add specialization NotNull<T*> with MOZ_NONNULL_RETURN attributes. r=#xpcom-reviewers

Depends on D71296

Comment 17

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 14: Add MOZ_NONNULL_RETURN attribute on NotNull::operator->. r=#xpcom-reviewers

Depends on D71298

Comment 18

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 15: Replace MOZ_NONNULL_RETURN by returning NotNull<elem_type*>. r=#xpcom-reviewers

Depends on D71299

Comment 19

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1628715 - Part 4bis: Make nsTArray*AllocatorBase methods constexpr. r=#xpcom-reviewers,nika

Depends on D70384

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f639011a7bbd
Part 1bis: Add nodiscard attribute to SwapElements. r=xpcom-reviewers,nika,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/6e6528dfcb64
Part 1: Add MOZ_NONNULL_RETURN attributes to some nsTArray functions. r=xpcom-reviewers,erahm
https://hg.mozilla.org/integration/autoland/rev/6bec0aa0bc30
Part 2: Disable copy assignment to FallibleTArray from infallible nsTArray. r=xpcom-reviewers,erahm
https://hg.mozilla.org/integration/autoland/rev/7b3f5e09731f
Part 3: Make fallible nsTArray::Assign nodiscard. r=xpcom-reviewers,erahm
https://hg.mozilla.org/integration/autoland/rev/25187269c1f7
Part 4bis: Make nsTArray*AllocatorBase methods constexpr. r=nika,xpcom-reviewers
https://hg.mozilla.org/integration/autoland/rev/32405f37c706
Part 4: Add MOZ_NONNULL_RETURN to infallible nsTArray::ReplaceElementsAt. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/57b27245870f
Part 5: Add MOZ_NONNULL_RETURN to infallible nsTArray::InsertElementsAt. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/0d7fd40a8167
Part 6: Remove unused and redundant AppendElements overload. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/172770f1f622
Part 7bis: Add gtests for nsTArray::AppendElements. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/581ca795e0d4
Part 7: Add MOZ_NONNULL_RETURN to infallible nsTArray::AppendElements. r=xpcom-reviewers,necko-reviewers,nika,valentin
https://hg.mozilla.org/integration/autoland/rev/c86649abd7f2
Part 8: Add MOZ_NONNULL_RETURN to ReconstructElementAt. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/63944721b070
Part 9: Add MOZ_NONNULL_RETURN to InsertElementSorted. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/d6ceb381cd5f
Part 10: Activate nodiscard attributes on AppendElement(s). r=xpcom-reviewers,nika,peterv
https://hg.mozilla.org/integration/autoland/rev/95b61550e69d
Part 11: Add nodiscard attribute to functions unrelated to memory allocation. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/5bfc1b8e4bbc
Part 12: Add WrapNotNullUnchecked for NotNull<T*>. r=xpcom-reviewers,nika,jwalden
https://hg.mozilla.org/integration/autoland/rev/35beba65da53
Part 13: Add specialization NotNull<T*> with MOZ_NONNULL_RETURN attributes. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/945f2b8355e7
Part 14: Add MOZ_NONNULL_RETURN attribute on NotNull::operator->. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/d313c99bc1a5
Part 15: Replace MOZ_NONNULL_RETURN by returning NotNull<elem_type*>. r=xpcom-reviewers,necko-reviewers,dragana,nika

Comment 21

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f639011a7bbd
https://hg.mozilla.org/mozilla-central/rev/6e6528dfcb64
https://hg.mozilla.org/mozilla-central/rev/6bec0aa0bc30
https://hg.mozilla.org/mozilla-central/rev/7b3f5e09731f
https://hg.mozilla.org/mozilla-central/rev/25187269c1f7
https://hg.mozilla.org/mozilla-central/rev/32405f37c706
https://hg.mozilla.org/mozilla-central/rev/57b27245870f
https://hg.mozilla.org/mozilla-central/rev/0d7fd40a8167
https://hg.mozilla.org/mozilla-central/rev/172770f1f622
https://hg.mozilla.org/mozilla-central/rev/581ca795e0d4
https://hg.mozilla.org/mozilla-central/rev/c86649abd7f2
https://hg.mozilla.org/mozilla-central/rev/63944721b070
https://hg.mozilla.org/mozilla-central/rev/d6ceb381cd5f
https://hg.mozilla.org/mozilla-central/rev/95b61550e69d
https://hg.mozilla.org/mozilla-central/rev/5bfc1b8e4bbc
https://hg.mozilla.org/mozilla-central/rev/35beba65da53
https://hg.mozilla.org/mozilla-central/rev/945f2b8355e7
https://hg.mozilla.org/mozilla-central/rev/d313c99bc1a5