Closed Bug 162893 Opened 22 years ago Closed 20 years ago

Favicons linked using a LINK element are not displayed

Categories

(Camino Graveyard :: Toolbars & Menus, defect)

Product:
Camino Graveyard
Component:
Toolbars & Menus
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Camino0.9

People

(Reporter: sfraser_bugs, Assigned: Usul)

References

(
URL
)

Details

Attachments

(1 file)

rought version 0.1 patch
10.60 KB, patch
Details | Diff | Splinter Review 
Mozilla.org uses a <link> in the <head> to specify the site icon, and Chimera
does not support that yet. We should, I think, because this is so much less evil
that Windows-format .ico files at the root of the site.
Indeed. What formats are allowed, tho? I use an animated gif right now for
Mozilla (http://homepage.mac.com/nikd/img/icon.gif), but would like to use a
transparent MNG version (can't cause there are no apps that handle MNG for the
Mac). Would any Quicktime compatible stuff work? :)

Imagine fav-movies in Flash or something...

Whatever NSImage supports (JPEG, GIF, PNG, PICT, TIFF etc). Forget about animations.
*** Bug 162925 has been marked as a duplicate of this bug. ***
Isn't this because Chimera only supports IE-style "favicon.ico" sitewide icons,
and not icons linked from individual pages? If so, the summary should be changed.
OS to Mac OS X
OS: Mac System 9.x → MacOS X
Nor does the favicon show up at www.apple.com. After further testing,  Chimera
does load the favicon if it's in the  same location as the page's index file on
the server. That's why a site will get a favicon displayed even though the HTML
has none specified:

http://www.macmerc.com/favicon.ico

http://www.mcdonalds.com/favicon.ico

http://developer.apple.com/favicon.ico

Apple's and Mozilla site don't have the favicon or png document in this
location. In addition, Chimera appears to ignore the HREF in the link element so
no icon is loaded. Does this sound right ? 
That's exactly what's happening.
*** Bug 172189 has been marked as a duplicate of this bug. ***
URL: http://www.mozilla.org → http://www.mozilla.org/
Summary: Site icon does not show up for mozilla.org → Chimera doesn't display page icons linked using a LINK element
*** Bug 193284 has been marked as a duplicate of this bug. ***
still true 2003090102 on 10.2.6.
*** Bug 235862 has been marked as a duplicate of this bug. ***
*** Bug 244280 has been marked as a duplicate of this bug. ***
Status: NEW → ASSIGNED
Summary: Chimera doesn't display page icons linked using a LINK element → Favicons linked using a LINK element are not displayed
Target Milestone: --- → Camino0.9
Assignee: sfraser → qa-mozilla
Status: ASSIGNED → NEW
Mozilla.org now uses the favicon at mozilla.org/favicon.ico. Same scheme with
Apple.com. Can somebody put up a test URL that we don't handle correctly?
http://www.derailer.org/temp/favicontest.html

New test URL. Should work at least until the bug is fixed (probably longer).
(In reply to comment #14)
> http://www.derailer.org/temp/favicontest.html
> 
> New test URL. Should work at least until the bug is fixed (probably longer).

Oops, I should add a small description here since one's not on the page (yet):

Camino shows the default /favicon.ico ("dp"), while Safari, etc. show the "h9" icon.
Blocks: 282647
hrm, this could be fairly involved. our siteIconProvider code makes some fairly
serious assumptions about being able to deduce the /favicon location from just
the url and not having to parse the page's html.

i'm not sure we can easily do this for 0.9 or even 1.0. i'll let simon comment
when he gets back from vacation.
(In reply to comment #16)
> hrm, this could be fairly involved. our siteIconProvider code makes some fairly
> serious assumptions about being able to deduce the /favicon location from just
> the url and not having to parse the page's html.
> 
> i'm not sure we can easily do this for 0.9 or even 1.0. i'll let simon comment
> when he gets back from vacation.

The solution is to hook up a DOM Event listener for DOMLinkAdded elements.
but then what do we do about favicons in bookmarks or history?
(In reply to comment #18)
> but then what do we do about favicons in bookmarks or history?

seems to me like the reasonable thing to do is to either cache the favicon
permanately when viewing the page, or not display it at all.  Probably you would
want an accompanying prefs option not to cache them so that people wouldn't need
to have that much disk usage if they didn't want to.

For that matter, do we need to see them?  as far as I can tell neither firefox
nor the trunk display icons in the menu and neither displays the site icon in
the bookmarks manager.

Just a thought.  Hope you can work something out.
Working patch. I'm seeking comment on :
  1) How can I dispaly the favicon before the page finihes loading.
  2) How should I deal with bookmarks
  3) Code corectness
I checked in code to support <link> site icons, based on this patch. Thanks for
the patch!
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
I should add that I also added a page URL -> site icon URL cache (by setting
metadata on necko cache descriptors) so that we can show linked icons for
bookmarks and history. If you crash and lose your necko cache, you will also
loose this mapping. Revisiting the page will re-establish it.
Just putting a comment here out of curiousity:

We still don't show favicons for local files (file:///test.html). These files
can specify favicons with <link> too, shouldn't we display them?

Is there something in the infrastructure that says we can't do this. 
Is there something in the user interaction that says we shouldn't do this?
englabenny@macnytt.com, please file a new bug regarding that behavior.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: