282647 - Tab site icon (favicon or globe icon) sometimes doesn't load / show.

Status: RESOLVED WORKSFORME

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Jasper]

In some cases (not 100% reproducable) the site icon or globe icon normally drawn
to the left of the site title isn't dranw on the tab. the nasty part that if it
isn't people aren't able to drag the tab title.

As I already said to Simon this reminds me of bug 157995: 
tab title stays at "Loading..." sometimes. This happens when we don't get a
setTitle: callback from gecko (e.g. for an FTP download), so always set the tab
title back to the page title (or URL) in onLoadingComplete.

This is also one of those small things that aren't very nice to come accross.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I see this (or something like it) all the time at weather.com
<http://www.weather.com/weather/local/USDC0001>

I can't for the life of me see a favicon called in that mess they call their
HTML code, but the default globe doesn't show up, either.  Sometimes I can drag
the blank spot, though, so this might be a different issue.

Comment 2

[Simon Fraser [no longer active]]

Weather.com's favicon is a blank gif (go figure). Get it with:

curl http://www.weather.com/favicon.ico > icon.gif

Comment 3

[Simon Fraser [no longer active]]

See also bug 162893.

Comment 4

[Jasper]

I'm adding some additional info as I think we really should fix this.

- when loading a tab group with buzilla querys it can happen that wehn opening
the new tabs no icon (globe or file) in shown.
- when switching to such a tab while still loading the file icon will appear,
while normally a loading website should show a globe!
- when a tab without the icon is loaded, and you then switch to it no icon will
show untill a reload.
- the really bad thing is that tabs where the icon doesn't load, the user can't
drag the tab title.

Concerning the file icon showing in the url bar and the tab titles, I was
wondering why we show that icon at all. Shouldn't we only show that icon when we
 loaded a file instead of a webpage (bug 156886) ? It seems odd to have 2 icons
for the same instance.

I think the following should be done:
- when we open a new window or tab, the globe icon should be used in all cases
unless a local file was opened. So the url bar and the tab titles should always
first load the globe icon.
- when we open a tab group first thing that should be done is set the tab icon,
then we can do everything else and when a site icon is found on the sever we
switch to that icon.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Jasper, do you still see any of these issues (aside from bug 156886-related ones)?

Comment 6

[Simon Fraser [no longer active]]

Still an issue?

Comment 7

[Jasper]

When ever you open a new tab by command clicking a bookmark or url, or when
opening a tab group, camino will always first show a tab with the "loading..."
text without a globe or file icon.

I think that when ever we create a new tab trough a bookmark/url/tabgroup we
always should display an icon.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Tweaking summary so it shows up in favicon query....

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This doesn't seem to happen anymore.