Closed Bug 1629039 Opened 4 months ago Closed 4 months ago

Limit rebuild for tasks which are restricted via try --full

Categories

(Firefox Build System :: Try, enhancement, P3)

enhancement

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: bc, Assigned: bc)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ci-costs-2020:done])

Attachments

(1 file)

We have placed a number of tasks behind the --full argument to mach try in order to limit the inadvertent triggering of uncommon tasks, or special cases or the use of platforms with limited hardware support. However we can still overload our systems when a developer uses --full along with a --rebuild argument.

We could limit the over use of these tasks by limiting the maximum effective value for --rebuild for --full only try tasks to a small value. jmaher suggests 3 would be a good choice though this might still cause issues with extremely limited hardware platforms such as android-hw. A warning message to the developer that their rebuild has been limited on these restricted platforms would be helpful as well.

It would still be possible to use a custom push action to specify a higher value but that is probably a good options in cases where a higher value is necessary. If custom push actions are abused and become a problem, we can take a look at limiting the times value there.

Whiteboard: [ci-costs-2020:todo]
Assignee: nobody → bob
Status: NEW → ASSIGNED
Pushed by bclary@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/630482eeb9cc
Limit --rebuild to 3 for mach try --full, r=jmaher.

Thanks!

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Whiteboard: [ci-costs-2020:todo] → [ci-costs-2020:done]
You need to log in before you can comment on or make changes to this bug.